Revert "ACPI: dock driver"
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 6 lines · Linux Kernel Mailing List
commit
953969ddf5b049361ed1e8471cc43dc4134d2a6f
treee4b84effa78a7e34d516142ee8ad1441906e33de
parentb862f3b099f3ea672c7438c0b282ce8201d39dfc
author Linus Torvalds <[email protected]> Sun, 09 Jul 2006 22:47:46 -0700 committer Linus Torvalds <[email protected]> Sun, 09 Jul 2006 22:47:46 -0700
Quoted 6 lines
Revert "ACPI: dock driver"
This reverts commit
a5e1b94008f2a96abf4a0c0371a55a56b320c13e.Adrian Bunk points out that it has build errors, and apparently no maintenance. Throw it out.
Erm, what do I miss? Code certainly builds, just before that checkin.
ppc:~$ ls -la /usr/src/linus/linux-2.6.18-rc1-b862/drivers/acpi/dock* -rw-r--r-- 1 root root 19474 Jul 9 17:04 /usr/src/linus/linux-2.6.18-rc1-b862/drivers/acpi/dock.c -rw-r--r-- 1 root root 148519 Jul 9 17:33 /usr/src/linus/linux-2.6.18-rc1-b862/drivers/acpi/dock.o ppc:~$ uname -a Linux ppc 2.6.18-rc1-b862 #1 SMP PREEMPT Sun Jul 9 17:53:48 CEST 2006 x86_64 GNU/Linux ppc:~$
Thanks,
Petr Vandrovec
Quoted 11 lines · Petr Vandrovec
Quoted 10 lines · Linux Kernel Mailing List
commit
953969ddf5b049361ed1e8471cc43dc4134d2a6f
treee4b84effa78a7e34d516142ee8ad1441906e33de
parentb862f3b099f3ea672c7438c0b282ce8201d39dfc
author Linus Torvalds <[email protected]> Sun, 09 Jul 2006 22:47:46 -0700
committer Linus Torvalds <[email protected]> Sun, 09 Jul 2006 22:47:46 -0700Revert "ACPI: dock driver"
Quoted 7 lines
Quoted 4 lines
This reverts commit
a5e1b94008f2a96abf4a0c0371a55a56b320c13e.Adrian Bunk points out that it has build errors, and apparently no maintenance. Throw it out.
Erm, what do I miss? Code certainly builds, just before that checkin.
...
Not with all .config's:
http://lkml.org/lkml/2006/6/25/126
http://lkml.org/lkml/2006/6/25/134
Quoted 2 lines
Thanks,
Petr Vandrovec
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 17 lines · On Sun, 9 Jul 2006 22:33:10 +0200 Adrian Bunk wrote:
Quoted 16 lines · Petr Vandrovec
Quoted 14 lines · Linux Kernel Mailing List
commit
953969ddf5b049361ed1e8471cc43dc4134d2a6f
treee4b84effa78a7e34d516142ee8ad1441906e33de
parentb862f3b099f3ea672c7438c0b282ce8201d39dfc
author Linus Torvalds <[email protected]> Sun, 09 Jul 2006 22:47:46 -0700
committer Linus Torvalds <[email protected]> Sun, 09 Jul 2006 22:47:46 -0700Revert "ACPI: dock driver"
This reverts commit
a5e1b94008f2a96abf4a0c0371a55a56b320c13e.Adrian Bunk points out that it has build errors, and apparently no maintenance. Throw it out.
Quoted 7 lines
Quoted 2 lines
Erm, what do I miss? Code certainly builds, just before that checkin.
...Not with all .config's:
http://lkml.org/lkml/2006/6/25/126
http://lkml.org/lkml/2006/6/25/134
I set ACPI_DOCK=m and it builds OK. I think that I used the other config options from Miles's email.
and it still builds OK for me.
Miles, can I get your full failing .config file, please?
---
~Randy
Quoted 24 lines · Randy.Dunlap
Quoted 22 lines · On Sun, 9 Jul 2006 22:33:10 +0200 Adrian Bunk wrote:
Quoted 11 lines · Petr Vandrovec
Quoted 10 lines · Linux Kernel Mailing List
commit
953969ddf5b049361ed1e8471cc43dc4134d2a6f
treee4b84effa78a7e34d516142ee8ad1441906e33de
parentb862f3b099f3ea672c7438c0b282ce8201d39dfc
author Linus Torvalds <[email protected]> Sun, 09 Jul 2006 22:47:46 -0700
committer Linus Torvalds <[email protected]> Sun, 09 Jul 2006 22:47:46 -0700Revert "ACPI: dock driver"
Quoted 7 lines
Quoted 4 lines
This reverts commit
a5e1b94008f2a96abf4a0c0371a55a56b320c13e.Adrian Bunk points out that it has build errors, and apparently no maintenance. Throw it out.
Erm, what do I miss? Code certainly builds, just before that checkin.
...Not with all .config's:
Quoted 7 lines
I set ACPI_DOCK=m and it builds OK. I think that I used the other config options from Miles's email.
and it still builds OK for me.
...
ACPI_DOCK=m, HOTPLUG_PCI_ACPI=y is the problematic configuration.
Quoted 1 line
~Randy
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 6 lines · Linux Kernel Mailing List
commit
953969ddf5b049361ed1e8471cc43dc4134d2a6f
treee4b84effa78a7e34d516142ee8ad1441906e33de
parentb862f3b099f3ea672c7438c0b282ce8201d39dfc
author Linus Torvalds <[email protected]> Sun, 09 Jul 2006 22:47:46 -0700 committer Linus Torvalds <[email protected]> Sun, 09 Jul 2006 22:47:46 -0700
Quoted 8 lines
Revert "ACPI: dock driver"
This reverts commit
a5e1b94008f2a96abf4a0c0371a55a56b320c13e.Adrian Bunk points out that it has build errors, and apparently no maintenance. Throw it out.
For the record, this driver is most definitely maintained (in fact I sent a patch for a different problem on Friday). Thank you to Len for sorting this all out. It's been a busy 2 weeks.
Kristen