Skip to contentSkip to conversation

-Wshadow: Add -Wshadow to toplevel Makefile

RFC PATCH In review Jesper Juhl 2 participants 3 messages Jul 10, 2006 Kbuild

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/9 -Wshadow: Add -Wshadow to toplevel Makefile

(please see the mail titled
"[RFC][PATCH 0/9] -Wshadow: Making the kernel build clean with -Wshadow" for an explanation of why I'm doing this)

Add -Wshadow to the top-level Makefile.

---

 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Makefile renamed from Makefile.orig +2 -2
@@ -188,7 +188,7 @@
 
 HOSTCC       = gcc
 HOSTCXX      = g++
-HOSTCFLAGS   = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
+HOSTCFLAGS   = -Wall -Wshadow -Wstrict-prototypes -O2 -fomit-frame-pointer
 HOSTCXXFLAGS = -O2
 
 # Decide whether to build built-in, modular, or both.
@@ -307,7 +307,7 @@
 
 CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
 
-CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
+CFLAGS          := -Wall -Wshadow -Wundef -Wstrict-prototypes -Wno-trigraphs \
                    -fno-strict-aliasing -fno-common
 # Force gcc to behave correct even for buggy distributions
 CFLAGS          += $(call cc-option, -fno-stack-protector-all \
#1 lore raw
Quoted 3 lines · Jesper Juhl

(please see the mail titled
"[RFC][PATCH 0/9] -Wshadow: Making the kernel build clean with -Wshadow" for an explanation of why I'm doing this)

I can't. You seem to have forgotten to send your sequence of emails as a _thread_.

Signature · 1 line
dwmw2
#2 lore raw
Quoted 8 lines · David Woodhouse
Quoted 3 lines · Jesper Juhl

(please see the mail titled
"[RFC][PATCH 0/9] -Wshadow: Making the kernel build clean with -Wshadow" for an explanation of why I'm doing this)

I can't. You seem to have forgotten to send your sequence of emails as a _thread_.

Yeah I screwed up a bit :-(
0/9 is on LKML now though. If you want I can also forward you a copy.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html