make sound/isa/gus/gusextreme.c:devices static

PATCH Applied Adrian Bunk 2 participants 2 messages Jul 10, 2006 – Jul 11, 2006 Sound

lore

Share & tools

lore

Adrian Bunk

author

2006-07-10 22:02 UTC #0 lore raw

PATCH 1/1 make sound/isa/gus/gusextreme.c:devices static

"devices" is not a good name for a global variable.

Thankfully, it can become static.

Signed-off-by Adrian Bunk <[email protected]>

sound/isa/gus/gusextreme.c renamed from sound/isa/gus/gusextreme.c.old +1 -1

@@ -87,7 +87,7 @@
 module_param_array(pcm_channels, int, NULL, 0444);
 MODULE_PARM_DESC(pcm_channels, "Reserved PCM channels for GUS Extreme driver.");
 
-struct platform_device *devices[SNDRV_CARDS];
+static struct platform_device *devices[SNDRV_CARDS];
 
 
 #define PFX	"gusextreme: "

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Takashi Iwai

Applied

2006-07-11 10:17 UTC #1 lore raw

At Tue, 11 Jul 2006 00:02:36 +0200,

Quoted 6 lines · Adrian Bunk

"devices" is not a good name for a global variable.
Thankfully, it can become static.
Signed-off-by Adrian Bunk <[email protected]>

Applied to ALSA tree now. Thanks.

Takashi

Quoted 16 lines

sound/isa/gus/gusextreme.c renamed from sound/isa/gus/gusextreme.c.old +1 -2

@@ -87,7 +87,7 @@
 module_param_array(pcm_channels, int, NULL, 0444);
 MODULE_PARM_DESC(pcm_channels, "Reserved PCM channels for GUS Extreme driver.");
 
-struct platform_device *devices[SNDRV_CARDS];
+static struct platform_device *devices[SNDRV_CARDS];
 
 
 #define PFX	"gusextreme: "
 
 
 
-------------------------------------------------------------------------

Quoted 9 lines

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel