put xen console message into syslog but xm dmesg is not affected
PATCH 2/4 put xen console message into syslog but xm dmesg is not affected
[2/4] add xenlogd daemon for xen console logging
tools/misc/Makefile +2 -2
@@ -13,10 +13,10 @@ CFLAGS += $(INCLUDES) HDRS = $(wildcard *.h) -TARGETS = xenperf xc_shadow +TARGETS = xenperf xc_shadow xenlogd INSTALL_BIN = $(TARGETS) xencons -INSTALL_SBIN = netfix xm xen-bugtool xend xenperf +INSTALL_SBIN = netfix xm xen-bugtool xend xenperf xenlogd .PHONY: all all: build
tools/misc/xenlogd.c new file +299 -0
299 lines not on this page · raw message
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Quoted 3 lines · MINAI Katsuhito
[2/4] add xenlogd daemon for xen console logging
Signed-off-by Katsuhito Minai <[email protected]>
Let's not add extra code styles to the tree: either format your code in Xen style (4-space soft tabs; braces on their own lines) or in Linux style (hard tabs; K&R style).
-- Keir
Re: [PATCH] [2/4] put xen console message into syslog butxm dmesg is not affected
Hi keir
I am sorry that the code style of my patch is scattering.
After the discussion with you concerning xc_readconsolering() reached a conclusion, I'd like to re-contribute the patch to match the code style of Xen.
Best regards,
Katsuhito Minai
Quoted 19 lines · Keir Fraser
Quoted 3 lines · MINAI Katsuhito
[2/4] add xenlogd daemon for xen console logging
Signed-off-by Katsuhito Minai <[email protected]>Let's not add extra code styles to the tree: either format your code in Xen style (4-space soft tabs; braces on their own lines) or in Linux style (hard tabs; K&R style).
-- Keir
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Re: [PATCH] [2/4] put xen console message into syslog but?xm dmesg is not affected
In reply to Keir FraserQuoted 10 lines · Keir Fraser
Quoted 3 lines · MINAI Katsuhito
[2/4] add xenlogd daemon for xen console logging
Signed-off-by Katsuhito Minai <[email protected]>Let's not add extra code styles to the tree: either format your code in Xen style (4-space soft tabs; braces on their own lines) or in Linux style (hard tabs; K&R style).
Two is already one too many IMHO :-)
Signature · 3 lines
Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/
Re: [PATCH] [2/4] put xen console message into syslog but?xm dmesg is not affected
Quoted 5 lines · Horms
Quoted 3 lines
Let's not add extra code styles to the tree: either format your code in Xen style (4-space soft tabs; braces on their own lines) or in Linux style (hard tabs; K&R style).
Two is already one too many IMHO :-)
As long as each discrete 'tool' or library is self-consistent in which it picks I don't really see a problem. In fact I wouldn't be too bothered about having more than two styles to choose from -- but two-space soft tabs are not an option as far as I'm concerned, which is the main reason I commented. There are more important issues than petty battles over coding standards.
-- Keir
Re: [PATCH] [2/4] put xen console message into syslog but?xm dmesg is not affected
Quoted 8 lines · Keir Fraser
Quoted 5 lines · Horms
Quoted 4 lines
Let's not add extra code styles to the tree: either format your code in
Xen style (4-space soft tabs; braces on their own lines) or in Linux style (hard tabs; K&R style).
Quoted 8 lines
Quoted 1 line
Two is already one too many IMHO :-)
As long as each discrete 'tool' or library is self-consistent in which it picks I don't really see a problem. In fact I wouldn't be too bothered about having more than two styles to choose from -- but two-space soft tabs are not an option as far as I'm concerned, which is the main reason I commented. There are more important issues than petty battles over coding standards.
Sorry, I was niggling a bit. I don't mind too much either, as long as its clear which directories (or files) use which standard. Though it is a bit of a mind-warp when you have files from xen/ and some kernel files open at the same time. I had to get quite good at teaching my editor what to do for me.
Signature · 3 lines
Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/