net/core/user_dma.c should #include <net/netdma.h>
Subsystems (2)
PATCH 1/1 net/core/user_dma.c should #include <net/netdma.h>
Every file should #include the headers containing the prototypes for its global functions.
Especially in cases like this one where gcc can tell us through a compile error that the prototype was wrong...
Signed-off-by Adrian Bunk <[email protected]>
---
include/net/netdma.h | 2 +- net/core/user_dma.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)
include/net/netdma.h renamed from include/net/netdma.h.old +1 -1
@@ -37,7 +37,7 @@ }int dma_skb_copy_datagram_iovec (struct dma_chan * chan, -const struct sk_buff *skb,int offset,struct iovec *to, +struct sk_buff *skb,int offset,struct iovec *to,size_t len,struct dma_pinned_list *pinned_list);#endif /* CONFIG_NET_DMA */
net/core/user_dma.c renamed from net/core/user_dma.c.old +1 -0
@@ -29,6 +29,7 @@#include <linux/socket.h> #include <linux/rtnetlink.h> /* for BUG_TRAP */ #include <net/tcp.h> +#include <net/netdma.h> #define NET_DMA_DEFAULT_COPYBREAK 4096
From: Adrian Bunk <[email protected]>
Date: Sat, 15 Jul 2006 02:36:17 +0200
Quoted 7 lines
Every file should #include the headers containing the prototypes for its global functions.
Especially in cases like this one where gcc can tell us through a compile error that the prototype was wrong...
Signed-off-by Adrian Bunk <[email protected]>
Applied, thanks Adrian.