skge: chip clock rate typo
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 skge: chip clock rate typo
Michael Buesch spotted this typo. The impact is that the incorrect value was being computed for blinking LED and interrupt moderation values.
drivers/net/skge.c +1 -1
@@ -519,7 +519,7 @@ static inline u32 hwkhz(const struct skgif (hw->chip_id ==CHIP_ID_GENESIS )return 53215 ;/* or: 53.125 MHz */ else -return 78215 ;/* or: 78.125 MHz */ +return 78125 ;/* or: 78.125 MHz */ }/* Chip HZ to microseconds */
drivers/net/skge.c static inline u32 hwkhz(const struct skg · line 520
Quoted 10 lines · Stephen Hemminger
Michael Buesch spotted this typo. The impact is that the incorrect value was being computed for blinking LED and interrupt moderation values.
Signed-off-by Stephen Hemminger <[email protected]>drivers/net/skge.c +0
-0@@ -519,7 +519,7 @@ static inline u32 hwkhz(const struct skgif (hw->chip_id ==CHIP_ID_GENESIS )return 53215 ;/* or: 53.125 MHz */
-------------------------^ Should this be 53125?
Larry
Quoted 6 lines · On Mon, 24 Jul 2006 16:34:46 -0500 Larry Finger <[email protected]>…
Quoted 5 lines · Stephen Hemminger
Michael Buesch spotted this typo. The impact is that the incorrect value was being computed for blinking LED and interrupt moderation values.
Signed-off-by Stephen Hemminger <[email protected]>
Quoted 9 lines
drivers/net/skge.c static inline u32 hwkhz(const struct skg · line 520
Quoted 5 lines
drivers/net/skge.c +0
-0@@ -519,7 +519,7 @@ static inline u32 hwkhz(const struct skgif (hw->chip_id ==CHIP_ID_GENESIS )return 53215 ;/* or: 53.125 MHz */ -------------------------^ Should this be 53125?
Larry
yup
PATCH 1/1 skge: chip clock rate typo
In reply to Stephen HemmingerOkay, Fix both typo's in one patch .The impact is that the incorrect value was being computed for blinking LED and interrupt moderation values.
drivers/net/skge.c +1 -4
@@ -516,10 +516,7 @@ static int skge_set_pauseparam(struct ne/* Chip internal frequency for clock calculations */ static inline u32 hwkhz (const struct skge_hw *hw) { -if (hw->chip_id ==CHIP_ID_GENESIS ) -return 53215 ;/* or: 53.125 MHz */ -else -return 78215 ;/* or: 78.125 MHz */ +return (hw->chip_id ==CHIP_ID_GENESIS ) ?53125 :78125 ; }/* Chip HZ to microseconds */