Skip to contentSkip to conversation

Display "gitweb/test/file with spaces" in gitk

PATCH In review Thomas Kolejka 2 participants 2 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Display "gitweb/test/file with spaces" in gitk

Hello,

with this patch files with spaces in their names are displayed in the treeview of gitk.

I use git to make a "backup"/"dump" of a DOS-FS .. and there are those filenames ;-).

Take care .. it's my first tcl hack!

Thomas

--

gitk +2 -2
index ba4644f..93af19c 100755
@@ -3938,7 +3938,7 @@ proc gettreeline {gtf id} {
     while {[gets $gtf line] >= 0} {
        if {[lindex $line 1] ne "blob"} continue
        set sha1 [lindex $line 2]
-       set fname [lindex $line 3]
+       set fname [join [lrange $line 3 end]]
        lappend treefilelist($id) $fname
        lappend treeidlist($id) $sha1
     }
@@ -4147,7 +4147,7 @@ proc gettreediffline {gdtf ids} {
        }
        return
     }
-    set file [lindex $line 5]
+    set file [join [lrange $line 5 end]]
     lappend treediff $file
 }
 
Signature · 2 lines
Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen!
Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer
#1 lore raw
Quoted 5 lines · Thomas Kolejka

with this patch files with spaces in their names are displayed in the treeview of gitk.

I use git to make a "backup"/"dump" of a DOS-FS .. and there are those filenames ;-).

Hmmm, certainly my code is incorrect. However with your code, tabs in the filename will get changed to spaces. Treating the line read from git-ls-tree or git-diff-tree was a shortcut hack that isn't really optimal. I'll think about the best way to fix it.

Paul.