spinlock_debug: don't recompute (jiffies_per_loop * HZ) in spinloop
PATCH 1/1 spinlock_debug: don't recompute (jiffies_per_loop * HZ) in spinloop
In spinlock_debug.c, the spinloops call __delay() on every iteration. Because that is an external function, (jiffies_per_loop * HZ), the loop's iteration limit, gets recomputed every time. Caching it explicitly prevents that.
Signed-off-by Chuck Ebbert <[email protected]>
---
__delay() should really be declared __attribute_pure.
lib/spinlock_debug.c +9 -6
@@ -99,11 +99,12 @@ static inline void debug_spin_unlock(spistatic void __spin_lock_debug (spinlock_t *lock) { -int print_once =1 ;u64 i; +u64 loops = loops_per_jiffy *HZ ; +int print_once =1 ;for (;;) { -for (i =0 ; i < loops_per_jiffy *HZ ; i++) { +for (i =0 ; i < loops; i++) {if (__raw_spin_trylock (&lock->raw_lock))return ;__delay (1 );
@@ -164,11 +165,12 @@ static void rwlock_bug(rwlock_t *lock, cstatic void __read_lock_debug (rwlock_t *lock) { -int print_once =1 ;u64 i; +u64 loops = loops_per_jiffy *HZ ; +int print_once =1 ;for (;;) { -for (i =0 ; i < loops_per_jiffy *HZ ; i++) { +for (i =0 ; i < loops; i++) {if (__raw_read_trylock (&lock->raw_lock))return ;__delay (1 );
@@ -237,11 +239,12 @@ static inline void debug_write_unlock(rwstatic void __write_lock_debug (rwlock_t *lock) { -int print_once =1 ;u64 i; +u64 loops = loops_per_jiffy *HZ ; +int print_once =1 ;for (;;) { -for (i =0 ; i < loops_per_jiffy *HZ ; i++) { +for (i =0 ; i < loops; i++) {if (__raw_write_trylock (&lock->raw_lock))return ;__delay (1 );
Signature · 1 line
Chuck