incorrect usage of UTS_RELEASE in bcm43xx_get_drvinfo
Subsystems (2)
bcm43xx_get_drvinfo in 2.6.18-rc2 unfortunately uses UTS_RELEASE as driver version. I think this specific info can be obtained by other ways.
Can you give bcm43xx a real version number and provide it via the ethtool ioctl?
It will trigger a rebuild if the uname -r of the kernel to build changes.
Quoted 6 lines · Olaf Hering
bcm43xx_get_drvinfoin 2.6.18-rc2 unfortunately usesUTS_RELEASEas driver version. I think this specific info can be obtained by other ways.
Can you give bcm43xx a real version number and provide it via the ethtool ioctl?
I am not going to maintain a bogus version number. What about simply returning 1.0 and be done with it. I don't think it matters. 1.0 is as bogus as any other value.
Signature · 1 line
Greetings Michael.
Quoted 11 lines · Michael Buesch
Quoted 6 lines · Olaf Hering
bcm43xx_get_drvinfoin 2.6.18-rc2 unfortunately usesUTS_RELEASEas driver version. I think this specific info can be obtained by other ways.
Can you give bcm43xx a real version number and provide it via the ethtool ioctl?I am not going to maintain a bogus version number. What about simply returning 1.0 and be done with it. I don't think it matters. 1.0 is as bogus as any other value.
I'm less concerned about the actual number, just UTS_RELEASE should disappear, and the #include.
Quoted 3 lines · Michael Buesch
I am not going to maintain a bogus version number. What about simply returning 1.0 and be done with it. I don't think it matters. 1.0 is as bogus as any other value.
Put it to use! Increment it whenever there's a major change in the driver, like the locking rewrite or the init routine rewrite. At the very least, it makes it easier to rule certain things out if a user reports lockup or something.
Jason
Quoted 6 lines · Jason Lunz
Quoted 3 lines · Michael Buesch
I am not going to maintain a bogus version number. What about simply returning 1.0 and be done with it. I don't think it matters. 1.0 is as bogus as any other value.
Put it to use! Increment it whenever there's a major change in the
What is a major change? Why only on major change? Why not on simple changes, too? Simple changes sometimes introduce bugs, too.
Quoted 3 lines
driver, like the locking rewrite or the init routine rewrite. At the very least, it makes it easier to rule certain things out if a user reports lockup or something.
What I wanted to say: I _never_ had debugging-problems, because I did not know the source state it was compiled from.
If there is a lockup, and I don't see if a specific change that might cause it is in or not, I simply ask him. It's _much_ easier than maintaining a bogus counter.
The version counter will cause patch hunks to fail and whatever. It's only useless trouble.
If someone is not able to answer questions like:
"Which kernel version do you run?"
"Please look at foo.c line 234 and tell me what's there." He does not want to debug the problem anyway. Problem solved. Someone else will appear to help debugging it, if it's a real bug.
Signature · 1 line
Greetings Michael.
Quoted 2 lines · Michael Buesch
What is a major change? Why only on major change? Why not on simple changes, too? Simple changes sometimes introduce bugs, too.
the version number has whatever meaning you choose to assign to it. Including none, if you so choose.
Quoted 2 lines
What I wanted to say: I _never_ had debugging-problems, because I did not know the source state it was compiled from.
fair enough. The version field certainly doesn't seem to get much use in other net drivers.
Jason