Skip to contentSkip to conversation

OMAP: Fix RNG driver build

PATCH In review Komal Shah 3 participants 3 messages Jul 22, 2006 – Aug 7, 2006

lore
Share & tools
lore

Komal Shah

author
#0 lore raw

PATCH 1/1 OMAP: Fix RNG driver build

Attached patch fixes the following RNG driver build warnings and errors:

drivers/char/hw_random/omap-rng.c:33:32: asm/hardware/clock.h: No such file or directory drivers/char/hw_random/omap-rng.c: In function `omap_rng_probe':
drivers/char/hw_random/omap-rng.c:88: warning: implicit declaration of function `to_platform_device' drivers/char/hw_random/omap-rng.c:88: warning: initialization makes pointer from integer without a cast drivers/char/hw_random/omap-rng.c:99: warning: implicit declaration of function clk_get' drivers/char/hw_random/omap-rng.c:99: warning: assignment makes pointer from integer without a cast drivers/char/hw_random/omap-rng.c:106: warning: implicit declaration of function clk_use' drivers/char/hw_random/omap-rng.c:110: warning: implicit declaration of function `platform_get_resource' drivers/char/hw_random/omap-rng.c:110: warning: assignment makes pointer from integer without a cast drivers/char/hw_random/omap-rng.c:115: error: dereferencing pointer to incomplete type drivers/char/hw_random/omap-rng.c: In function `omap_rng_remove':
drivers/char/hw_random/omap-rng.c:148: warning: implicit declaration of function clk_unuse' drivers/char/hw_random/omap-rng.c:149: warning: implicit declaration of function clk_put' drivers/char/hw_random/omap-rng.c: At top level:
drivers/char/hw_random/omap-rng.c:184: error: `platform_bus_type' undeclared here (not in a function) drivers/char/hw_random/omap-rng.c:184: error: initializer element is not constant drivers/char/hw_random/omap-rng.c:184: error: (near initialization for `omap_rng_driver.bus')

Please give your Signed-off-by: line if it is OK.

---Komal Shah
http://komalshah.blogspot.com

Signature · 2 lines
http://www.fastmail.fm - Faster than the air-speed velocity of an
                          unladen european swallow
#1 lore raw
Quoted 3 lines · Komal Shah

Michael/Deepak/Juha,

Attached patch fixes the following RNG driver build warnings and errors:

I don't have the hardware, so I can't test this. Deepak, do you have the hardware and can you ack this?

Signature · 1 line
Greetings Michael.
#2 lore raw
Quoted 7 lines · Michael Buesch
Quoted 3 lines · Komal Shah

Michael/Deepak/Juha,

Attached patch fixes the following RNG driver build warnings and errors:

I don't have the hardware, so I can't test this. Deepak, do you have the hardware and can you ack this?

This is safe to push and has been used in the linux-omap tree.