i386: add CFI macros for stack manipulation
In-Reply-To: <[email protected]>
Quoted 11 lines · Andi Kleen
Quoted 2 lines · Chuck Ebbert
Add macros to
dwarf2.hto simplify pushing and popping stack variables.I feared someone would do that patch. I've thought about it myself.
However it's not a good idea. I've already had complaints that some code in x86-64 is too hard to read/debug because it uses too many macros. I think it's better if the core core still uses "real" instructions and keep the CFI_* stuff as annotation that most people can just ignore.
I did this because it should prevent:
| Date: Thu, 27 Jul 2006 07:45:35 +0200 | From: Markus Armbruster <[email protected]> | Subject: [PATCH] Fix trivial unwind info bug | To: [email protected] | Message-ID: <[email protected]> | Content-Type: text/plain; charset=us-ascii | | CFA needs to be adjusted upwards for push, and downwards for pop. | arch/i386/kernel/entry.S gets it wrong in one place. | | Signed-off-by: Markus Armbruster <[email protected]> | | | diff --git a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S | index d9a260f..37a7d2e 100644 | --- a/arch/i386/kernel/entry.S | +++ b/arch/i386/kernel/entry.S | @@ -204,7 +204,7 @@ #define RING0_PTREGS_FRAME \ | ENTRY(ret_from_fork) | CFI_STARTPROC | pushl %eax | - CFI_ADJUST_CFA_OFFSET -4 | + CFI_ADJUST_CFA_OFFSET 4 | call schedule_tail | GET_THREAD_INFO(%ebp) | popl %eax
Otherwise I was just going to indent the annotations an additional tabstop to move them out of the way. (They really annoy me.)
Signature · 1 line
Chuck
Quoted 2 lines · Chuck Ebbert
Otherwise I was just going to indent the annotations an additional tabstop to move them out of the way. (They really annoy me.)
That would annoy me then.
-Andi