2.6.18-rc2-mm1: unresolved symbol brnf_deferred_hooks in xt_physdev module
Subsystems (2)
PATCH 1/1 2.6.18-rc2-mm1: unresolved symbol brnf_deferred_hooks in xt_physdev module
The (trivial) patch below fixes the unresolved symbol brnf_deferred_hooks in the xt_physdev module in 2.6.18-rc2-mm1.
---
--- linux-2.6.17/net/netfilter/xt_physdev.c.ark 2006-07-28 13:34:31.000000000
+0200
+++ linux-2.6.17/net/netfilter/xt_physdev.c 2006-07-28 13:34:48.000000000
+0200
@@ -16,6 +16,8 @@
#define MATCH 1
#define NOMATCH 0
+extern int brnf_deferred_hooks;
+
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Bart De Schuymer <[email protected]>"); MODULE_DESCRIPTION("iptables bridge physical device match module");
Quoted 11 lines · On Fri, 28 Jul 2006 13:38:21 +0200 Bernhard Rosenkraenzer <[email protected]>…
The (trivial) patch below fixes the unresolved symbol
brnf_deferred_hooksin thext_physdevmodule in 2.6.18-rc2-mm1.Signed-off-by Bernhard Rosenkraenzer <[email protected]>---
--- linux-2.6.17/net/netfilter/xt_physdev.c.ark 2006-07-28 13:34:31.000000000
+0200
+++linux-2.6.17/net/netfilter/xt_physdev.c2006-07-28 13:34:48.000000000
+0200
Review line 23
Quoted 8 lines
(quoted diff) +2
-0@@ -16,6 +16,8 @@ #define MATCH 1 #define NOMATCH 0 +extern int brnf_deferred_hooks; + MODULE_LICENSE("GPL"); MODULE_AUTHOR("Bart De Schuymer <[email protected]>"); MODULE_DESCRIPTION("iptables bridge physical device match module");
OK, but please never put extern declarations in .c files. They need to go in a header where the compiler can check that the variable's type is consistent at all usage sites.
We already have such a declaration, so I guess this is the fix:
net/netfilter/xt_physdev.c renamed from net/netfilter/xt_physdev.c~xt_physdev-build-fix +1 -0
@@ -10,6 +10,7 @@#include <linux/module.h> #include <linux/skbuff.h> +#include <linux/netfilter/netfilter_bridge.h> #include <linux/netfilter/xt_physdev.h> #include <linux/netfilter/x_tables.h> #include <linux/netfilter_bridge.h>
_
Your email client is wordwrapping patches, btw. There's a lot of it going round at present.