x86_64: fix is_at_popf() for compat tasks
PATCH 1/1 x86_64: fix is_at_popf() for compat tasks
When testing for the REX instruction prefix, first check for a 32-bit task because in compat mode the REX prefix is an increment instruction.
Signed-off-by Chuck Ebbert <[email protected]>
---
Compiled and booted but needs a test case...
arch/x86_64/kernel/ptrace.c +4 -1
@@ -141,8 +141,11 @@ static int is_at_popf(struct task_structcase 0xf0 :case 0xf2 :case 0xf3 :continue ; -/* REX prefixes */ case 0x40 ... 0x4f: +if (is_compat_task ()) +/* register increment */ +return 0 ; +/* REX prefix */ continue ;/* CHECKME: f0, f2, f3 */
Signature · 1 line
Chuck
Quoted 3 lines · Chuck Ebbert
When testing for the REX instruction prefix, first check for a 32-bit task because in compat mode the REX prefix is an increment instruction.
is_compat_task doesn't actually say that a task is in compat mode (it refers to the Linux compat layer, not x86-64 compat mode)
A better test would be regs->cs == __USER32_CS, but in theory there could be other code segments in LDT. I guess that can be ignored though.
-Andi