Skip to contentSkip to conversation

remove bogomips from /proc/cpuinfo

PATCH In review Olaf Hering 4 participants 5 messages Jul 31, 2006 PowerPC

lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

PATCH 1/1 remove bogomips from /proc/cpuinfo

Remove bogomips from /proc/cpuinfo.
It is now really bogus since "timebase-frequency" is shown.

Signed-off-by Olaf Hering <[email protected]>
---
 arch/powerpc/kernel/setup-common.c |   14 --------------
 1 file changed, 14 deletions(-)
arch/powerpc/kernel/setup-common.c +0 -14
Index: linux-2.6.18-rc3/arch/powerpc/kernel/setup-common.c
===================================================================
@@ -163,14 +163,6 @@ static int show_cpuinfo(struct seq_file 
 	unsigned short min;
 
 	if (cpu_id == NR_CPUS) {
-#if defined(CONFIG_SMP) && defined(CONFIG_PPC32)
-		unsigned long bogosum = 0;
-		int i;
-		for_each_online_cpu(i)
-			bogosum += loops_per_jiffy;
-		seq_printf(m, "total bogomips\t: %lu.%02lu\n",
-			   bogosum/(500000/HZ), bogosum/(5000/HZ) % 100);
-#endif /* CONFIG_SMP && CONFIG_PPC32 */
 		seq_printf(m, "timebase\t: %lu\n", ppc_tb_freq);
 		if (ppc_md.name)
 			seq_printf(m, "platform\t: %s\n", ppc_md.name);

@@ -263,12 +255,6 @@ static int show_cpuinfo(struct seq_file 
 	seq_printf(m, "revision\t: %hd.%hd (pvr %04x %04x)\n",
 		   maj, min, PVR_VER(pvr), PVR_REV(pvr));
 
-#ifdef CONFIG_PPC32
-	seq_printf(m, "bogomips\t: %lu.%02lu\n",
-		   loops_per_jiffy / (500000/HZ),
-		   (loops_per_jiffy / (5000/HZ)) % 100);
-#endif
-
 #ifdef CONFIG_SMP
 	seq_printf(m, "\n");
 #endif
#1 lore raw
Quoted 2 lines · Olaf Hering

Remove bogomips from /proc/cpuinfo.
It is now really bogus since "timebase-frequency" is shown.

Well, but it's still part of the ABI, right?
How do you determine that there are no broken applications still relying on it?

	Arnd <><
author
#2 lore raw
Quoted 7 lines · Arnd Bergmann
Quoted 2 lines · Olaf Hering

Remove bogomips from /proc/cpuinfo.
It is now really bogus since "timebase-frequency" is shown.

Well, but it's still part of the ABI, right?
How do you determine that there are no broken applications still relying on it?

Everything works on a G5, as example. Alpha doesnt have it either. What pratical value had bogomips for an application?

#3 lore raw
Quoted 6 lines · Olaf Hering
Quoted 4 lines · Arnd Bergmann
Quoted 2 lines · Olaf Hering

Remove bogomips from /proc/cpuinfo.
It is now really bogus since "timebase-frequency" is shown.

Quoted 6 lines
Quoted 3 lines

Well, but it's still part of the ABI, right?
How do you determine that there are no broken applications still relying on it?

Everything works on a G5, as example. Alpha doesnt have it either. What pratical value had bogomips for an application?

What harm does it do?

Andreas.

Signature · 4 lines
Andreas Schwab, SuSE Labs, [email protected]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
#4 lore raw
Quoted 8 lines · Andreas Schwab
Quoted 6 lines · Olaf Hering
Quoted 4 lines · Arnd Bergmann
Quoted 2 lines · Olaf Hering

Remove bogomips from /proc/cpuinfo.
It is now really bogus since "timebase-frequency" is shown.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Well, but it's still part of the ABI, right?
How do you determine that there are no broken applications still relying on it?

Everything works on a G5, as example. Alpha doesnt have it either. What pratical value had bogomips for an application?

What harm does it do?

Kernel bloat.

--linas