Fix Freescale high-speed USB host dependency
Subsystems (2)
PATCH 1/1 Fix Freescale high-speed USB host dependency
The high-speed USB SOC only exists on MPC834x family not MPC83xx family.
---
drivers/usb/host/ehci-hcd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/ehci-hcd.c +0 -0
@@ -892,7 +892,7 @@ #include "ehci-pci.c"
#define EHCI_BUS_GLUED
#endif
-#ifdef CONFIG_PPC_83xx
+#ifdef CONFIG_MPC834x
#include "ehci-fsl.c"
#define EHCI_BUS_GLUED
#endif
Quoted 26 lines · Li Yang
The high-speed USB SOC only exists on MPC834x family not MPC83xx family.
Signed-off-by Li Yang <[email protected]>---
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/host/ehci-hcd.c +1
-1@@ -892,7 +892,7 @@ #include "ehci-pci.c"#define EHCI_BUS_GLUED #endif -#ifdef CONFIG_PPC_83xx +#ifdef CONFIG_MPC834x#include "ehci-fsl.c" #define EHCI_BUS_GLUED #endif _______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev
RE: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency
Another one in header file.
---
drivers/usb/host/ehci.h +0 -0
@@ -642,7 +642,7 @@ #endif
=20 /*---------------------------------------------------------------------- ---*/
-#ifdef CONFIG_PPC_83xx
+#ifdef CONFIG_MPC834x
/* Some Freescale processors have an erratum in which the TT
* port number in the queue head was 0..N-1 instead of 1..N. */
Quoted 3 lines
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of
Kumar Gala
Quoted 5 lines
Sent: Friday, July 14, 2006 9:52 PM
To: Li Yang-r58472
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB
hostdependency
Quoted 28 lines
=20
Acked-by Kumar Gala <[email protected]>=20
On Jul 14, 2006, at 6:58 AM, Li Yang wrote:
=20Quoted 23 lines
The high-speed USB SOC only exists on MPC834x family not MPC83xx family.
Signed-off-by Li Yang <[email protected]>---
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/host/ehci- renamed from drivers/usb/host/ehci-hcd.c +0
-0
hcd.cindex 79f2d8b..3af1844 100644drivers/usb/host/ehci-hcd.c +1
-1@@ -892,7 +892,7 @@ #include "ehci-pci.c"#define EHCI_BUS_GLUED #endif -#ifdef CONFIG_PPC_83xx +#ifdef CONFIG_MPC834x#include "ehci-fsl.c" #define EHCI_BUS_GLUED #endif
Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency
Quoted 9 lines · On Jul 20, 2006, at 6:42 AM, Li Yang-r58472 wrote:
Another one in header file.
---
drivers/usb/host/ehci.h +0
-0@@ -642,7 +642,7 @@ #endif
drivers/usb/host/ehci.h #endif
Quoted 10 lines
drivers/usb/host/ehci.h +1
-3/*--------------------------------------------------------------------- - ---*/ -#ifdef CONFIG_PPC_83xx +#ifdef CONFIG_MPC834x /* Some Freescale processors have an erratum in which the TT * port number in the queue head was 0..N-1 instead of 1..N. */
Do we really want to make this change. What harm is there in having the ehci support for MPC834x build on all 83xx processors? I can't imagine we are going to config in support for ehci on anything that is MPC834x at this point and if you do, your device tree isn't going to have nodes in it so the drivers not going to bind against anything.
Finally, I got to believe Freescale's going to build some MPC83xx in the future with the high speed USB IP.
- kumar
Quoted 40 lines
Quoted 4 lines
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf OfKumar Gala
Quoted 5 lines
Sent: Friday, July 14, 2006 9:52 PM
To: Li Yang-r58472
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USBhostdependency
Quoted 28 lines
Acked-by Kumar Gala <[email protected]>Quoted 23 lines · Li Yang
The high-speed USB SOC only exists on MPC834x family not MPC83xx family.
Signed-off-by Li Yang <[email protected]>---
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/host/ehci- renamed from drivers/usb/host/ehci-hcd.c +0
-0
hcd.cindex 79f2d8b..3af1844 100644drivers/usb/host/ehci-hcd.c +1
-1@@ -892,7 +892,7 @@ #include "ehci-pci.c"#define EHCI_BUS_GLUED #endif -#ifdef CONFIG_PPC_83xx +#ifdef CONFIG_MPC834x#include "ehci-fsl.c" #define EHCI_BUS_GLUED #endif
Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency
Quoted 18 lines · Kumar Gala
Quoted 15 lines · On Jul 20, 2006, at 6:42 AM, Li Yang-r58472 wrote:
Another one in header file.
---
drivers/usb/host/ehci.h +0
-0@@ -642,7 +642,7 @@ #endif/
*---------------------------------------------------------------------
-
---*/
Quoted 12 lines
drivers/usb/host/ehci.h
Quoted 5 lines
drivers/usb/host/ehci.h +1
-1-#ifdef CONFIG_PPC_83xx +#ifdef CONFIG_MPC834x/* Some Freescale processors have an erratum in which the TT * port number in the queue head was 0..N-1 instead of 1..N. */ Do we really want to make this change. What harm is there in having the ehci support for MPC834x build on all 83xx processors? I can't imagine we are going to config in support for ehci on anything that is MPC834x at this point and if you do, your device tree isn't going to have nodes in it so the drivers not going to bind against anything.
It's not very harmful. But it will cause some misunderstanding. There were already some guys trying to use the 834x USB driver on 836x and 832x. Anyway, it's a trivial patch. Please apply if it doesn't cause much trouble.
Quoted 2 lines
Finally, I got to believe Freescale's going to build some MPC83xx in the future with the high speed USB IP.
I can't tell exactly. But it's not likely to integrate this IP into a chip with QE/CPM support. As QE/CPM has already provided full speed USB support, and the USB speed is not very important for Netcomm processors.
Quoted 49 lines
- kumar
Quoted 34 lines
Quoted 4 lines
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf OfKumar Gala
Quoted 5 lines
Sent: Friday, July 14, 2006 9:52 PM
To: Li Yang-r58472
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USBhostdependency
Quoted 23 lines
Acked-by Kumar Gala <[email protected]>Quoted 18 lines · Li Yang
The high-speed USB SOC only exists on MPC834x family not MPC83xx family.
Signed-off-by Li Yang <[email protected]>---
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/host/ehci- renamed from drivers/usb/host/ehci-hcd.c +0
-0
hcd.cindex 79f2d8b..3af1844 100644drivers/usb/host/ehci-hcd.c +0
-0@@ -892,7 +892,7 @@ #include "ehci-pci.c"#define EHCI_BUS_GLUED #endif Quoted 6 lines
Quoted 5 lines
drivers/usb/host/ehci-hcd.c #include "ehci-pci.c" · line 898
Quoted 5 lines
drivers/usb/host/ehci-hcd.c +1
-1-#ifdef CONFIG_PPC_83xx +#ifdef CONFIG_MPC834x#include "ehci-fsl.c" #define EHCI_BUS_GLUED #endif _______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency
Quoted 34 lines · Li Yang
Quoted 20 lines · Kumar Gala
Quoted 10 lines · On Jul 20, 2006, at 6:42 AM, Li Yang-r58472 wrote:
Another one in header file.
---
drivers/usb/host/ehci.h +0
-0@@ -642,7 +642,7 @@ #endifQuoted 2 lines
/
*--------------------------------------------------------------------
-Quoted 3 lines
-
---*/Quoted 12 lines
drivers/usb/host/ehci.h
Quoted 5 lines
drivers/usb/host/ehci.h +1
-1-#ifdef CONFIG_PPC_83xx +#ifdef CONFIG_MPC834x/* Some Freescale processors have an erratum in which the TT * port number in the queue head was 0..N-1 instead of 1..N. */ Do we really want to make this change. What harm is there in having the ehci support for MPC834x build on all 83xx processors? I can't imagine we are going to config in support for ehci on anything that is MPC834x at this point and if you do, your device tree isn't going to have nodes in it so the drivers not going to bind against anything.
Quoted 4 lines
It's not very harmful. But it will cause some misunderstanding. There were already some guys trying to use the 834x USB driver on 836x and 832x. Anyway, it's a trivial patch. Please apply if it doesn't cause much trouble.
Is that more because the QE drivers aren't in the kernel tree?
Quoted 7 lines
Quoted 2 lines
Finally, I got to believe Freescale's going to build some MPC83xx in the future with the high speed USB IP.
I can't tell exactly. But it's not likely to integrate this IP into a chip with QE/CPM support. As QE/CPM has already provided full speed USB support, and the USB speed is not very important for Netcomm processors.
True, but not all 83xx are Netcomm processors.
- k
Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency
Quoted 48 lines · Kumar Gala
Quoted 35 lines · Li Yang
Quoted 20 lines · Kumar Gala
Quoted 10 lines · On Jul 20, 2006, at 6:42 AM, Li Yang-r58472 wrote:
Another one in header file.
---
drivers/usb/host/ehci.h +0
-0@@ -642,7 +642,7 @@ #endifQuoted 2 lines
/
*--------------------------------------------------------------------
-Quoted 3 lines
-
---*/Quoted 13 lines
drivers/usb/host/ehci.h
Quoted 5 lines
drivers/usb/host/ehci.h +1
-1-#ifdef CONFIG_PPC_83xx +#ifdef CONFIG_MPC834x/* Some Freescale processors have an erratum in which the TT * port number in the queue head was 0..N-1 instead of 1..N. */ Do we really want to make this change. What harm is there in having the ehci support for MPC834x build on all 83xx processors? I can't imagine we are going to config in support for ehci on anything that is MPC834x at this point and if you do, your device tree isn't going to have nodes in it so the drivers not going to bind against anything.
Quoted 4 lines
It's not very harmful. But it will cause some misunderstanding. There were already some guys trying to use the 834x USB driver on 836x and 832x. Anyway, it's a trivial patch. Please apply if it doesn't cause much trouble.
Is that more because the QE drivers aren't in the kernel tree?
Quoted 3 lines
Quoted 2 lines
Finally, I got to believe Freescale's going to build some MPC83xx in the future with the high speed USB IP.
Quoted 6 lines
Quoted 4 lines
I can't tell exactly. But it's not likely to integrate this IP into a chip with QE/CPM support. As QE/CPM has already provided full speed USB support, and the USB speed is not very important for Netcomm processors.
True, but not all 83xx are Netcomm processors.
83xx=PowerQUICC II Pro, IMHO.
I just give my 2 cents. It's up to you to decide as you are the maintainer. :)
Quoted 8 lines
- k
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency
In reply to Kumar GalaQuoted 3 lines · Kumar Gala
Review
Quoted 3 lines
(quoted diff) +1
-1-#ifdef CONFIG_PPC_83xx +#ifdef CONFIG_MPC834x
So at the end of all that discussion, was there a USB patch to merge? If so, I don't see one in my mail folder.
Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency
Quoted 8 lines · David Brownell
Quoted 3 lines · Kumar Gala
Review
Quoted 3 lines
(quoted diff) +1
-1-#ifdef CONFIG_PPC_83xx +#ifdef CONFIG_MPC834xSo at the end of all that discussion, was there a USB patch to merge? If so, I don't see one in my mail folder.
Not on this side of things. If we clean up the CONFIG_PPC stuff I'll push that through the PPC maintainer. There was a patch for gadget support for the controller, but not sure if you handle that or not.
- k