Skip to contentSkip to conversation

x86_64: remove lock prefix from is_at_popf() tests

PATCH In review Chuck Ebbert 2 participants 2 messages Aug 1, 2006 ptrace support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86_64: remove lock prefix from is_at_popf() tests

The lock prefix will cause an exception when used with the popf instruction, so no need to continue searching after it's found.

arch/x86_64/kernel/ptrace.c +2 -2
@@ -138,7 +138,7 @@ static int is_at_popf(struct task_struct
 		case 0x26: case 0x2e:
 		case 0x36: case 0x3e:
 		case 0x64: case 0x65:
-		case 0xf0: case 0xf2: case 0xf3:
+		case 0xf2: case 0xf3:
 			continue;
 
 		case 0x40 ... 0x4f:
@@ -148,7 +148,7 @@ static int is_at_popf(struct task_struct
 			/* 64-bit mode: REX prefix */
 			continue;
 
-			/* CHECKME: f0, f2, f3 */
+			/* CHECKME: f2, f3 */
 
 		/*
 		 * pushf: NOTE! We should probably not let
Signature · 1 line
Chuck
#1 lore raw
Quoted 3 lines · Chuck Ebbert

The lock prefix will cause an exception when used with the popf instruction, so no need to continue searching after it's found.

Applied thanks.
-Andi