Skip to contentSkip to conversation

pccards are not detected

DISCUSSION Daniel Ritz 2 participants 2 messages Aug 2, 2006 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 1154551499.7714.13.camel@dv

#3 lore raw
Quoted 27 lines · Pavel Roskin
Quoted 5 lines · Daniel Ritz
Quoted 3 lines · Pavel Roskin

It depends. For some custom systems, BIOS may be a lifesaver. Let's not change the whole logic of the PCI detection because of one broken BIOS.

Quoted 8 lines

errm. 2.6.16 automatically uses direct access. if first shows the PCI BIOS line, then the direct access line in dmesg. pci_raw_ops is first set to PCI_BIOS to be overwritten with direct access immediatley after that.

eg. from a 2.6.16.20 on a buggy box:

	PCI: PCI BIOS revision 2.10 entry at 0xfb9a0, last bus=0
	PCI: Using configuration type 1

cardbus would be bus 1-4. 2.6.17 breaks here...

If it's a laptop and CardBus is integrated, it's a BIOS bug. BIOS should know about integrated hardware. No excuses.

Quoted 6 lines
Quoted 2 lines

The standard solution for such problems is to add a "quirk" to drivers/pci/quirks.c or arch/i386/kernel/quirks.c

no. it is a clear regression and the patch in fact just restores the old behaviour with the exception that the ordering is more clear now than it was before...

My intention was just to remind you about the quirks.

Quoted 8 lines
Quoted 3 lines

2.6.16: pci bios comes first, is overriden by direct access
2.6.17: pci bios comes first. direct access is never used if pci bios probe "worked" 2.6.17+patch: pci direct access probed first, if it fails pci bios is used.

The way you put it above, it sounds like a major change. But I missed the actual patch. Maybe it just reorders a few printk()s compared to 2.6.16, I don't know.

ok, in other words:
2.6.16: end result: direct access; if direct doesn't work: pcibios 2.6.17: end result: pci bios (only direct if pcibios fails! ) 2.6.17+patch: end result: direct access; if direct doesn't work: pcibios => net result is the same, but less code is executed, order is clear always.

Quoted 4 lines

I still believe that adding quirk would be a good solution, in particular because it would work even if direct PCI probing is disabled. And then you can reorder the probing as much as you want.

no, a quirk is bad for the simple reason that 2.6.16 used to work on systems (laptops) where 2.6.17 fails for cardbus...there's no way you can wait on all the reports and add quirks for them one-by-one. and distros are still using kernel < 2.6.17...

btw. it's commit 92c05fc1a32e5ccef5e0e8201f32dcdab041524c ([PATCH] PCI: Give PCI config access initialization a defined ordering) that broke things on those laptops. cc'ing Andi...

Andi, for reference:
http://marc.theaimsgroup.com/?l=linux-kernel&m=115454028402107

rgds
-daniel

#4 lore raw
Quoted 6 lines

ok, in other words:
2.6.16: end result: direct access; if direct doesn't work: pcibios 2.6.17: end result: pci bios (only direct if pcibios fails! ) 2.6.17+patch: end result: direct access; if direct doesn't work: pcibios => net result is the same, but less code is executed, order is clear always.

Makes sense. PCI BIOS access is totally obsolete and should only be used when everything else fails.

Quoted 3 lines

btw. it's commit 92c05fc1a32e5ccef5e0e8201f32dcdab041524c ([PATCH] PCI: Give PCI config access initialization a defined ordering) that broke things on those laptops. cc'ing Andi...

It could have broken before where the order was essentially random.

-Andi