2.4.33-rc3 needs to export memchr() for smbfs
PATCH 1/1 2.4.33-rc3 needs to export memchr() for smbfs
Hi Marcelo,
just finished building 2.4.33-rc3 on my dual-CPU Sun U60 (works fine BTW). I noticed that smbfs built as a module needs memchr() since a recent fix, so this one now needs to be exported, which this patch does. Sources show that the lp driver would need it too is console on LP is enabled and LP is set as a module (which seems stupid to me anyway). I've pushed it into -upstream if you prefer to pull from it.
Overall, 2.4.33-rc3 seems to be OK to me. I don't think that an additionnal -rc4 would be needed just for this export (Grant CCed in case he's wishing to do a few more builds, you know him... :-) ).
Regards,
Willy
Quoted 1 line
From
e3523609bec99d5c607fc00b4f68386d3390fb82Mon Sep 17 00:00:00 2001
From: Willy Tarreau <[email protected]>
Date: Wed, 2 Aug 2006 23:30:22 +0200
Subject: [PATCH] export memchr() which is used by smbfs and lp driver.
Recently, an smbfs fix added a dependency on memchr() which is not exported if smbfs is built as a module.
--- kernel/ksyms.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/ksyms.c +1 -0
@@ -579,6 +579,7 @@ EXPORT_SYMBOL(get_write_access);EXPORT_SYMBOL (strnicmp);EXPORT_SYMBOL (strspn);EXPORT_SYMBOL (strsep); +EXPORT_SYMBOL (memchr);#ifdef CONFIG_CRC32 EXPORT_SYMBOL (crc32_le);
Signature · 1 line
1.4.1
Quoted 10 lines · Willy Tarreau
Hi Marcelo,
just finished building 2.4.33-rc3 on my dual-CPU Sun U60 (works fine BTW). I noticed that smbfs built as a module needs
memchr()since a recent fix, so this one now needs to be exported, which this patch does. Sources show that the lp driver would need it too is console on LP is enabled and LP is set as a module (which seems stupid to me anyway). I've pushed it into -upstream if you prefer to pull from it.
Quoted 4 lines
Overall, 2.4.33-rc3 seems to be OK to me. I don't think that an additionnal -rc4 would be needed just for this export (Grant CCed in case he's wishing to do a few more builds, you know him... :-) ).
Just one build, deltree server 'cos it exports some shares to 'doze boxen. Seems to be okay without the patch but...
Makes no difference to my limited usage here. Didn't break ;)
<http://bugsplatter.mine.nu/test/boxen/deltree/> *-rc3a
uptime 21 mins...
Cheers,
Grant.
Quoted 17 lines · Grant Coady
Quoted 10 lines · Willy Tarreau
Hi Marcelo,
just finished building 2.4.33-rc3 on my dual-CPU Sun U60 (works fine BTW). I noticed that smbfs built as a module needs
memchr()since a recent fix, so this one now needs to be exported, which this patch does. Sources show that the lp driver would need it too is console on LP is enabled and LP is set as a module (which seems stupid to me anyway). I've pushed it into -upstream if you prefer to pull from it.Quoted 4 lines
Overall, 2.4.33-rc3 seems to be OK to me. I don't think that an additionnal -rc4 would be needed just for this export (Grant CCed in case he's wishing to do a few more builds, you know him... :-) ).
Quoted 4 lines
Just one build, deltree server 'cos it exports some shares to 'doze boxen. Seems to be okay without the patch but...
Makes no difference to my limited usage here. Didn't break ;)
Interesting, I wonder whether memchr() may be a gcc builtin on some archs, explaining why it works without the patch on your machine.
Quoted 3 lines
<http://bugsplatter.mine.nu/test/boxen/deltree/> *-rc3a
uptime 21 mins...
Thanks very much, that's exactly what I needed.
Quoted 2 lines
Cheers,
Grant.
Cheers,
Willy
Quoted 18 lines · Willy Tarreau
Quoted 17 lines · Grant Coady
Quoted 14 lines · Willy Tarreau
Hi Marcelo,
just finished building 2.4.33-rc3 on my dual-CPU Sun U60 (works fine BTW). I noticed that smbfs built as a module needs
memchr()since a recent fix, so this one now needs to be exported, which this patch does. Sources show that the lp driver would need it too is console on LP is enabled and LP is set as a module (which seems stupid to me anyway). I've pushed it into -upstream if you prefer to pull from it.Overall, 2.4.33-rc3 seems to be OK to me. I don't think that an additionnal -rc4 would be needed just for this export (Grant CCed in case he's wishing to do a few more builds, you know him... :-) ).
Quoted 7 lines
Quoted 4 lines
Just one build, deltree server 'cos it exports some shares to 'doze boxen. Seems to be okay without the patch but...
Makes no difference to my limited usage here. Didn't break ;)
Interesting, I wonder whether
memchr()may be a gcc builtin on some archs, explaining why it works without the patch on your machine.
Compile host is Slackware-10.2, and:
~$ gcc --version
gcc (GCC) 3.3.6
Grant.
Quoted 23 lines · Grant Coady
Quoted 21 lines · Willy Tarreau
Quoted 20 lines · Grant Coady
Quoted 10 lines · Willy Tarreau
Hi Marcelo,
just finished building 2.4.33-rc3 on my dual-CPU Sun U60 (works fine BTW). I noticed that smbfs built as a module needs
memchr()since a recent fix, so this one now needs to be exported, which this patch does. Sources show that the lp driver would need it too is console on LP is enabled and LP is set as a module (which seems stupid to me anyway). I've pushed it into -upstream if you prefer to pull from it.Quoted 4 lines
Overall, 2.4.33-rc3 seems to be OK to me. I don't think that an additionnal -rc4 would be needed just for this export (Grant CCed in case he's wishing to do a few more builds, you know him... :-) ).
Just one build, deltree server 'cos it exports some shares to 'doze boxen. Seems to be okay without the patch but...
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Makes no difference to my limited usage here. Didn't break ;)
Interesting, I wonder whether
memchr()may be a gcc builtin on some archs, explaining why it works without the patch on your machine.Compile host is Slackware-10.2, and:
~$ gcc --version
gcc (GCC) 3.3.6
OK, I used gcc-3.3.5 on sparc64.
Quoted 1 line
Grant.
Willy