Skip to contentSkip to conversation

llc: multicast receive device match

PATCH In review Stephen Hemminger 2 participants 2 messages Aug 3, 2006 – Aug 11, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 llc: multicast receive device match

Fix from [email protected], STP packets are incorrectly received on all LLC datagram sockets, whichever interface they are bound to.
The llc_sap datagram receive logic sends packets with a unicast destination MAC to one socket bound to that SAP and MAC, and multicast packets to all sockets bound to that SAP. STP packets are multicast, and we do need to know on which interface they were received.

---
 net/llc/llc_sap.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
net/llc/llc_sap.c +3 -0
index 42eb0c3..61cb8cf 100644
@@ -330,6 +330,9 @@ static void llc_sap_mcast(struct llc_sap
 		if (llc->laddr.lsap != laddr->lsap)
 			continue;
 
+		if (llc->dev != skb->dev)
+			continue;
+
 		skb1 = skb_clone(skb, GFP_ATOMIC);
 		if (!skb1)
 			break;
Signature · 4 lines
1.4.0


-- 
maintainer
#1 lore raw

From: Stephen Hemminger <[email protected]>
Date: Thu, 3 Aug 2006 10:05:58 -0700

Quoted 8 lines

Fix from [email protected], STP packets are incorrectly received on all LLC datagram sockets, whichever interface they are bound to.
The llc_sap datagram receive logic sends packets with a unicast destination MAC to one socket bound to that SAP and MAC, and multicast packets to all sockets bound to that SAP. STP packets are multicast, and we do need to know on which interface they were received.

Looks correct, I will apply this.

Thanks a lot.