pSeries hvsi char driver null pointer deref
PATCH 1/1 pSeries hvsi char driver null pointer deref
Andrew,
Please apply.
Under certain rare circumstances, it appears that there can be be a NULL-pointer deref when a user fiddles with terminal emeulation programs while outpu is being sent to the console. This patch checks for and avoids a NULL-pointer deref.
----
drivers/char/hvsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/char/hvsi.c +2 -1
@@ -311,7 +311,8 @@ static void hvsi_recv_control(struct hvs/* CD went away; no more connection */ pr_debug ("hvsi%i: CD dropped\n" , hp->index); hp->mctrl &=TIOCM_CD ; -if (!(hp->tty->flags &CLOCAL )) +/* If userland hasn't done an open(2) yet, hp->tty is NULL. */ +if (hp->tty && !(hp->tty->flags &CLOCAL )) *to_hangup = hp->tty; }break ;
Quoted 10 lines · Linas Vepstas
Andrew,
Please apply.Under certain rare circumstances, it appears that there can be be a NULL-pointer deref when a user fiddles with terminal emeulation programs while outpu is being sent to the console. This patch checks for and avoids a NULL-pointer deref.
Signed-off-by Hollis Blanchard <[email protected]>Signed-off-by Linas Vepstas <[email protected]>
That email address is incorrect.
Quoted 22 lines
----
drivers/char/hvsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Index:
linux-2.6.18-rc3-git1/drivers/char/hvsi.c
===================================================================drivers/char/hvsi.c +2
-1@@ -311,7 +311,8 @@ static void hvsi_recv_control(struct hvs/* CD went away; no more connection */ pr_debug ("hvsi%i: CD dropped\n" , hp->index); hp->mctrl &=TIOCM_CD ; -if (!(hp->tty->flags &CLOCAL )) +/* If userland hasn't done an open(2) yet, hp->tty is NULL. */ +if (hp->tty && !(hp->tty->flags &CLOCAL )) *to_hangup = hp->tty; }break ;_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev