[PATCH] pxa2xx-i2sound · kernelthread

Giorgio Padrin

author

2006-08-05 17:37 UTC #0 lore raw

PATCH 1/1 pxa2xx-i2sound

Hi,

This is minimal patch updating the pxa2xx-i2sound code in alsa-driver.

Giorgio

arm/pxa2xx-i2sound.c +1 -3

diff -up a/arm/pxa2xx-i2sound.c b/arm/pxa2xx-i2sound.c
@@ -730,9 +730,7 @@ static int snd_pxa2xx_i2sound_card_creat
 			continue;
 		s = &card.engine.streams[s_id];
 		s->id = s_id;
-		s->ahw.info		= SNDRV_PCM_INFO_MMAP |
-					  SNDRV_PCM_INFO_INTERLEAVED |
-					  SNDRV_PCM_INFO_MMAP_VALID |
+		s->ahw.info		= SNDRV_PCM_INFO_INTERLEAVED |
 					  SNDRV_PCM_INFO_BLOCK_TRANSFER;
 		s->ahw.formats		= SNDRV_PCM_FMTBIT_S16_LE;
 		s->ahw.channels_min		= 2;

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Jaroslav Kysela

Applied

2006-08-05 17:53 UTC #1 lore raw

Quoted 3 lines · Giorgio Padrin

Hi,
This is minimal patch updating the pxa2xx-i2sound code in alsa-driver.

Applied, but please, be more verbose in future:

1) one-line patch summary is missing (what patch does)
2) explanation why this patch is required is missing
3) Signed-off-by line is missing

I know, it's really simple patch, but I don't know exactly which problems are with the mmap access on the pxa platform (probably DMA memory area coherency, right?).

Thanks,
Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project, SUSE Labs

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Giorgio Padrin

author

2006-08-05 19:21 UTC #2 lore raw

Alle 19:53, sabato 5 agosto 2006, Jaroslav Kysela ha scritto:

Quoted 10 lines · Giorgio Padrin

Quoted 3 lines
Hi,
This is minimal patch updating the pxa2xx-i2sound code in alsa-driver.
Applied, but please, be more verbose in future:
1) one-line patch summary is missing (what patch does)
2) explanation why this patch is required is missing
3) Signed-off-by line is missing

You're right.

Quoted 4 lines

I know, it's really simple patch, but I don't know exactly which problems are with the mmap access on the pxa platform (probably DMA memory area coherency, right?).

I didn't investigate the issue; I disabled mmapped access mode by prudence.

Giorgio

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Takashi Iwai

2006-08-07 16:40 UTC #3 lore raw

At Sat, 5 Aug 2006 21:21:08 +0200,

Quoted 13 lines · Giorgio Padrin

Alle 19:53, sabato 5 agosto 2006, Jaroslav Kysela ha scritto:
Quoted 10 lines · Giorgio Padrin
Quoted 3 lines
Hi,
This is minimal patch updating the pxa2xx-i2sound code in alsa-driver.
Applied, but please, be more verbose in future:
1) one-line patch summary is missing (what patch does)
2) explanation why this patch is required is missing
3) Signed-off-by line is missing

Quoted 8 lines

You're right.
Quoted 4 lines
I know, it's really simple patch, but I don't know exactly which problems are with the mmap access on the pxa platform (probably DMA memory area coherency, right?).
I didn't investigate the issue; I disabled mmapped access mode by prudence.

MMAP_VALID is referred only in OSS emulation code...

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642