uda1380

Hi,

This is a patch updating the uda1380 code in alsa-driver.

Log: Fix recording, primarily.

Giorgio

diff -up a/i2c/Kconfig b/i2c/Kconfig
@@ -1,11 +1,3 @@
-menu "Codecs on the I2C bus"
-	depends on SND && I2C
-
 config SND_UDA1380
-	tristate "Codec Philips UDA1380"
 	depends on SND && I2C
-	help
-	  Support for codec Philips UDA1380 on the I2C bus.
-	  Automatically selected by glue code.
-
-endmenu
\ No newline at end of file
+	tristate

diff -up a/include/uda1380.h b/include/uda1380.h
@@ -1,5 +1,5 @@
 /*
- * Audio support for Philips UDA1380
+ * Audio support for codec Philips UDA1380
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as

@@ -8,10 +8,15 @@
  * Copyright (c) 2005 Giorgio Padrin <[email protected]>
  */
 
+#ifndef __SOUND_UDA1380_H
+#define __SOUND_UDA1380_H
+
 #include <linux/i2c.h>
 
-enum snd_uda1380_capture_source
-	{ SND_UDA1380_CAP_SOURCE_LINE_IN, SND_UDA1380_CAP_SOURCE_MIC };
+enum snd_uda1380_capture_source {
+	SND_UDA1380_CAP_SOURCE_LINE_IN,
+	SND_UDA1380_CAP_SOURCE_MIC
+};
 
 struct snd_uda1380 {
 	struct semaphore sem;

@@ -67,7 +72,7 @@ struct snd_uda1380 {
 int snd_uda1380_activate(struct snd_uda1380 *uda);
 
 void snd_uda1380_deactivate(struct snd_uda1380 *uda);
-int snd_uda1380_add_mixer_controls(struct snd_uda1380 *uda, snd_card_t *card);
+int snd_uda1380_add_mixer_controls(struct snd_uda1380 *uda, struct snd_card *card);
 int snd_uda1380_open_stream(struct snd_uda1380 *uda, int stream);
 int snd_uda1380_close_stream(struct snd_uda1380 *uda, int stream);
 int snd_uda1380_suspend(struct snd_uda1380 *uda, pm_message_t state);

@@ -75,3 +80,5 @@ int snd_uda1380_resume(struct snd_uda138
 
 void snd_uda1380_hp_connected(struct snd_uda1380 *uda, int connected); /* non atomic context */
 void snd_uda1380_hp_detected(struct snd_uda1380 *uda, int detected); /* atomic context */
+
+#endif /* __SOUND_UDA1380_H */

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Alle 21:25, sabato 5 agosto 2006, Giorgio Padrin ha scritto:

Log: Fix recording, primarily.
uda1380.c:
* Fix recording.
* snd_uda1380_i2c_probe(): refined precisely a mask in checking I2C addresses.
* snd_uda1380_actl_reg_elem_int_info(): fix a typo causing a warning.

uda1380.h:
* ALSA drop of snd_*_t typedefs for struct snd_* .

Kconfig:
* Clean useless display of selection.

Thanks,

Giorgio

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

At Tue, 8 Aug 2006 13:36:13 +0200,

Thanks, applied to HG tree.

BTW, this module still remains in alsa-driver tree. Shouldn't it be moved to alsa-kernel so that it will appear in linux kernel tree? Or, doesn't it work with the recent 2.6 kernels?

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642