Skip to contentSkip to conversation

cputable: Correct IBM/750CXe rev3.x setup

PATCH In review Nicolas DET 2 participants 2 messages Aug 6, 2006 – Aug 8, 2006 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cputable: Correct IBM/750CXe rev3.x setup

This patch simply add an entry in the cputable to recognize correctly the IBM750CXe rev3.1. Only rev 2.x was correctly detected before.

Your sincerly
Nicolas DET

arch/powerpc/kernel/cputable.c +12 -0
@@ -447,6 +447,18 @@
 		.cpu_setup		= __setup_cpu_750cx,
 		.platform		= "ppc750",
 	},
+	{	/* 750CXe rev 3.1 (0008x311) */
+		.pvr_mask		= 0xffff0fff,
+		.pvr_value		= 0x00080311,
+		.cpu_name		= "750CXe",
+		.cpu_features		= CPU_FTRS_750,
+		.cpu_user_features	= COMMON_USER,
+		.icache_bsize		= 32,
+		.dcache_bsize		= 32,
+		.num_pmcs		= 4,
+		.cpu_setup		= __setup_cpu_750cx,
+		.platform		= "ppc750",
+	},
 	{	/* 750CXe "Gekko" (83214) */
 		.pvr_mask		= 0xffffffff,
 		.pvr_value		= 0x00083214,
#1 lore raw
Quoted 3 lines · Nicolas DET

This patch simply add an entry in the cputable to recognize correctly the IBM750CXe rev3.1. Only rev 2.x was correctly detected before.

[Patch annoyingly as an attachment...]

+ { /* 750CXe rev 3.1 (0008x311) */
+ .pvr_mask = 0xffff0fff,
+ .pvr_value = 0x00080311,
+ .cpu_name = "750CXe",

Any reason to make this so specific? The rest of the entry is identical to the ones we have for PVR values 0x0008221x and 0x00083214 (except that you missed out PPC_FEATURE_PPC_LE). It looks to me like we could collapse all three into a single entry with a suitable pvr_mask value (say 0xffff0e00?).

(akpm - consider this a nack)

Paul.