+ sys_getppid-oopses-on-debug-kernel.patch added to -mm tree
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 16 lines · On Tue, Aug 08, 2006 at 07:32:51AM -0700, [email protected] wrote:
The patch titled
sys_getppid()oopses on debug kernelhas been added to the -mm tree. Its filename is
sys_getppid-oopses-on-debug-kernel.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this
------------------------------------------------------
Subject:sys_getppid()oopses on debug kernel
From: Kirill Korotaev <[email protected]>
Quoted 6 lines
sys_getppid()optimization can access a freed memory. On kernels withDEBUG_SLABturned ON, this results in Oops.Signed-off-by Kirill Korotaev <[email protected]>Cc <[email protected]>Signed-off-by Andrew Morton <[email protected]>
I'm probably missing something, but is it really valid to access freed kernel memory even if CONFIG_DEBUG_SLAB is off - as this patch does?
Cheers,
Muli
Quoted 20 lines · Muli Ben-Yehuda
Quoted 19 lines · On Tue, Aug 08, 2006 at 07:32:51AM -0700, [email protected] wrote:
The patch titled
sys_getppid()oopses on debug kernelhas been added to the -mm tree. Its filename is
sys_getppid-oopses-on-debug-kernel.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this
------------------------------------------------------
Subject:sys_getppid()oopses on debug kernel
From: Kirill Korotaev <[email protected]>
sys_getppid()optimization can access a freed memory. On kernels withDEBUG_SLABturned ON, this results in Oops.
Quoted 6 lines
Quoted 3 lines
Signed-off-by Kirill Korotaev <[email protected]>Cc <[email protected]>Signed-off-by Andrew Morton <[email protected]>I'm probably missing something, but is it really valid to access freed kernel memory even if
CONFIG_DEBUG_SLABis off - as this patch does?
There's a note right above the function that explains it:
* NOTE! This depends on the fact that even if we _do_
* get an old value of "parent", we can happily dereference
* the pointer (it was and remains a dereferencable kernel pointer
* no matter what): we just can't necessarily trust the result
* until we know that the parent pointer is valid.
HTH
Björn
Quoted 6 lines · Björn Steinbrink
There's a note right above the function that explains it:
* NOTE! This depends on the fact that even if we _do_
* get an old value of "parent", we can happily dereference
* the pointer (it was and remains a dereferencable kernel pointer
* no matter what): we just can't necessarily trust the result
* until we know that the parent pointer is valid.
Even without getting into just how ugly this is, is it really worth it?
Cheers,
Muli
Ar Maw, 2006-08-08 am 17:57 +0300, ysgrifennodd Muli Ben-Yehuda:
Quoted 11 lines · Björn Steinbrink
Quoted 7 lines
There's a note right above the function that explains it:
* NOTE! This depends on the fact that even if we _do_
* get an old value of "parent", we can happily dereference
* the pointer (it was and remains a dereferencable kernel pointer
* no matter what): we just can't necessarily trust the result
* until we know that the parent pointer is valid.Even without getting into just how ugly this is, is it really worth it?
It never was in my opinion but I lost that battle to Linus in 1.3.40 or so timescales. Given how critical getppid _isnt_ I don't see the point in being clever.
Quoted 2 lines
Quoted 2 lines
Even without getting into just how ugly this is, is it really worth it?
it is impossible to run debug kernels w/o this patch :/ or are you asking whether this optimization worth it?
What makes me worry is that this is a sign that vendors don't even bother to run debug kernels :((((
Quoted 3 lines
It never was in my opinion but I lost that battle to Linus in 1.3.40 or so timescales. Given how critical getppid _isnt_ I don't see the point in being clever.
Alan, if you sign off the patch I will prepare another one, which removes the optimization away and make it always safe.
Kirill
Quoted 7 lines · Kirill Korotaev
Quoted 2 lines
Quoted 2 lines
Even without getting into just how ugly this is, is it really worth it?
it is impossible to run debug kernels w/o this patch :/ or are you asking whether this optimization worth it?
What makes me worry is that this is a sign that vendors don't even bother to run debug kernels :((((
Fedora rawhide is nearly always shipping with DEBUG_SLAB enabled, and we didn't hit this once. Are you sure this is a problem with DEBUG_SLAB, and not DEBUG_PAGEALLOC ?
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 11 lines
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
Even without getting into just how ugly this is, is it really worth it?
it is impossible to run debug kernels w/o this patch :/ or are you asking whether this optimization worth it?
What makes me worry is that this is a sign that vendors don't even bother to run debug kernels :((((
Fedora rawhide is nearly always shipping with
DEBUG_SLABenabled, and we didn't hit this once. Are you sure this is a problem withDEBUG_SLAB, and notDEBUG_PAGEALLOC?
Sorry, it's my fault. Surely, CONFIG_DEBUG_PAGEALLOC.
Kirill
Quoted 5 lines · Kirill Korotaev
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Even without getting into just how ugly this is, is it really worth it?
it is impossible to run debug kernels w/o this patch :/ or are you asking whether this optimization worth it?
Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
What makes me worry is that this is a sign that vendors don't even bother to run debug kernels :((((
Fedora rawhide is nearly always shipping with
DEBUG_SLABenabled, and we didn't hit this once. Are you sure this is a problem withDEBUG_SLAB, and notDEBUG_PAGEALLOC?Sorry, it's my fault. Surely,
CONFIG_DEBUG_PAGEALLOC.
Then you're correct, vendors rarely turn this on :)
I do sometimes if I'm trying to chase down something particularly difficult, and it usually gets me a bunch of mail from users asking why 'everything got all slow', so it's a last-resort option rather than a 'on all the time' option.
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 5 lines
Then you're correct, vendors rarely turn this on :)
I do sometimes if I'm trying to chase down something particularly difficult, and it usually gets me a bunch of mail from users asking why 'everything got all slow', so it's a last-resort option rather than a 'on all the time' option.
Yeah, maybe it is a last resort option for users, but at least for internal testing it helps. We regularly run such debug kernel through testing cycle and it catches some races from time to time.
Kirill