UML - support checkstack
Subsystems (2)
PATCH 1/1 UML - support checkstack
Make checkstack work for UML. We need to pass the underlying architecture name, rather than "um" to checkstack.pl.
Makefile +5 -1
@@ -1315,9 +1315,13 @@ endif #ifeq ($(config-targets),1) endif #ifeq ($(mixed-targets),1) PHONY += checkstack kernelrelease kernelversion + +# Use $(SUBARCH) here instead of $(ARCH) so that this works for UML. +# In the UML case, $(SUBARCH) is the name of the underlying +# architecture, while for all other arches, it is the same as $(ARCH). checkstack: $(OBJDUMP) -d vmlinux $$(find . -name '*.ko') | \ - $(PERL) $(src)/scripts/checkstack.pl $(ARCH) + $(PERL) $(src)/scripts/checkstack.pl $(SUBARCH) kernelrelease: $(if $(wildcard include/config/kernel.release), $(Q)echo $(KERNELRELEASE), \
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Quoted 2 lines · Jeff Dike
Make checkstack work for UML. We need to pass the underlying architecture name, rather than "um" to checkstack.pl.
Does this do the right thing with something like Voyager?
Or should we just get together a small fund to send the remaining Voyager users proper computers?
Signature · 11 lines
Mathematics is the supreme nostalgia of our time. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ User-mode-linux-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Quoted 5 lines · Matt Mackall
Quoted 2 lines · Jeff Dike
Make checkstack work for UML. We need to pass the underlying architecture name, rather than "um" to checkstack.pl.
Does this do the right thing with something like Voyager?
SUBARCH has a different meaning here. For UML, it's the underlying, host, architecture, not a variant architecture like Voyager.
Quoted 3 lines
Or should we just get together a small fund to send the remaining Voyager users proper computers?
Yeah, that's a plan :-)
Jeff
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Quoted 9 lines · Jeff Dike
Quoted 5 lines · Matt Mackall
Quoted 2 lines · Jeff Dike
Make checkstack work for UML. We need to pass the underlying architecture name, rather than "um" to checkstack.pl.
Does this do the right thing with something like Voyager?
SUBARCH has a different meaning here. For UML, it's the underlying, host, architecture, not a variant architecture like Voyager.
Right, so it sounds like this breaks Voyager. Which I think means we ought to pass ARCH and SUBARCH and do the right thing inside checkstack.
Signature · 11 lines
Mathematics is the supreme nostalgia of our time. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ User-mode-linux-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Quoted 6 lines · Matt Mackall
Quoted 2 lines
SUBARCH has a different meaning here. For UML, it's the underlying, host, architecture, not a variant architecture like Voyager.
Right, so it sounds like this breaks Voyager. Which I think means we ought to pass ARCH and SUBARCH and do the right thing inside checkstack.
There is no use of the symbol SUBARCH in arch/i386. While this may be jarring to people who know and love Voyager, it doesn't break anything.
We could do what you suggest, but that sounds unnecessary.
I'd rather either
leave things as they are
rename SUBARCH
Jeff
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Quoted 8 lines · Jeff Dike
Quoted 6 lines · Matt Mackall
Quoted 2 lines
SUBARCH has a different meaning here. For UML, it's the underlying, host, architecture, not a variant architecture like Voyager.
Right, so it sounds like this breaks Voyager. Which I think means we ought to pass ARCH and SUBARCH and do the right thing inside checkstack.
Quoted 8 lines
There is no use of the symbol SUBARCH in
arch/i386. While this may be jarring to people who know and love Voyager, it doesn't break anything.We could do what you suggest, but that sounds unnecessary.
I'd rather either
leave things as they are
Yes, and make the script check if it ARCH=um or not (which is obvious for now - nobody really wants a clear abstraction here).
Quoted 1 line
rename SUBARCH
Signature · 5 lines
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade Chiacchiera con i tuoi amici in tempo reale! http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com
Quoted 5 lines · Jeff Dike
Make checkstack work for UML. We need to pass the underlying architecture name, rather than "um" to checkstack.pl.
Signed-off-by Jeff Dike <[email protected]>
Jörn
Signature · 2 lines
Geld macht nicht glücklich. Glück macht nicht satt.