d80211/bcm43xx: Modify struct ieee80211_rx_status for wireless statistics.
Subsystems (2)
PATCH 1/8 d80211/bcm43xx: Modify struct ieee80211_rx_status for wireless statistics.
Part 1 of 8 to add wireless statistics to the bcm43xx-d80211 system. This patch adds new variables to struct ieee80211_rx_status to contain the latest values for signal, noise, and the maximum value of the received ssi. These could be u8's, but I left them as integers in case other drivers needed larger values.
The patch is for the August 8 version of Linville's wireless-dev tree.
include/net/d80211.h +3 -0
@@ -205,6 +205,9 @@ struct ieee80211_rx_status {int channel;int phymode;int ssi; +int maxssi; +int signal; +int noise;int antenna;int rate;int flag;
Quoted 17 lines · Larry Finger
Part 1 of 8 to add wireless statistics to the bcm43xx-d80211 system. This patch adds new variables to struct
ieee80211_rx_statusto contain the latest values for signal, noise, and the maximum value of the received ssi. These could be u8's, but I left them as integers in case other drivers needed larger values.The patch is for the August 8 version of Linville's wireless-dev tree.
Signed-off-by Larry Finger <[email protected]>include/net/d80211.h +0
-0
include/net/d80211.h struct ieee80211_rx_status { · line 210
Quoted 6 lines
include/net/d80211.h +3
-0@@ -205,6 +205,9 @@ struct ieee80211_rx_status {int channel;int phymode;int ssi; +int maxssi; +int signal; +int noise;
Spacing? Looks like you're using real tabs here, but the current code uses 8 spaces instead. Not sure if that's a problem.
Dan
Quoted 9 lines
include/net/d80211.h +0
-1int antenna;int rate;int flag; -To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 16 lines · Dan Williams
include/net/d80211.h struct ieee80211_rx_status { · line 210
Quoted 12 lines · Larry Finger
include/net/d80211.h +3
-0@@ -205,6 +205,9 @@ struct ieee80211_rx_status {int channel;int phymode;int ssi; +int maxssi; +int signal; +int noise;Spacing? Looks like you're using real tabs here, but the current code uses 8 spaces instead. Not sure if that's a problem.
I am using tabs, which I think is the preferred way. I also remember that the rule is not to change the white space on things you are not touching. Is that correct?
Larry
Quoted 10 lines · Larry Finger
Quoted 5 lines · Dan Williams
include/net/d80211.h struct ieee80211_rx_status { · line 208
Quoted 2 lines
int ssi;include/net/d80211.h +1
-0+int maxssi;Spacing? Looks like you're using real tabs here, but the current code uses 8 spaces instead. Not sure if that's a problem.
I am using tabs, which I think is the preferred way. I also remember that the rule is not to change the white space on things you are not touching. Is that correct?
That's at least the way I would prefer to do this. Unrelated whitespace changes as part of a patch are almost always bad and large patch of modifying just the whitespaces around the tree is likely to add large number of conflicts for pending work that goes on at the moment.
Unfortunately, I forgot to replace this part when making the initial release of the Devicescape stack. I've always used tabs myself, but some of the areas of the code that I did not write was done using spaces. Anyway, this should move to using tabs over time whenever source code is being modified.
Signature · 1 line
Jouni Malinen PGP id EFC895FA