Skip to contentSkip to conversation

IPX changes introduce warning.

DISCUSSION Dave Jones 2 participants 2 messages Aug 9, 2006 – Aug 10, 2006

Subsystems (2)
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

We've just added an implicit declaration in the latest tree..

net/ipx/af_ipx.c: In function 'ipx_rcv':
net/ipx/af_ipx.c:1648: error: implicit declaration of function 'ipxhdr'

(Yes, my builds fail on -Werror-implicit, so that things like this get caught early)

Probably something simple like a missing #include, but I'm heading out the door right now :) I'll poke at it later if no-one has beaten me to it.

Dave

Signature · 1 line
http://www.codemonkey.org.uk
maintainer
#1 lore raw

From: Dave Jones <[email protected]>
Date: Wed, 9 Aug 2006 19:44:17 -0400

Quoted 9 lines

We've just added an implicit declaration in the latest tree..

net/ipx/af_ipx.c: In function 'ipx_rcv':
net/ipx/af_ipx.c:1648: error: implicit declaration of function 'ipxhdr'

(Yes, my builds fail on -Werror-implicit, so that things like this get caught early)

Probably something simple like a missing #include, but I'm heading out the door right now :) I'll poke at it later if no-one has beaten me to it.

I could have sworn this compiled in my tree, sorry.

Fix below. Greg, I'll queue this up to you in a GIT tree along with another fix later tonight.

Thanks Dave.

commit fff642570dc47ab76491fe81ee6599269c4eb13e

Author: David S. Miller <[email protected]>
Date:   Wed Aug 9 17:36:15 2006 -0700

[IPX]: Fix typo, ipxhdr() --> ipx_hdr()

Noticed by Dave Jones.

net/ipx/af_ipx.c +1 -1
index 4019642..bef3f61 100644
@@ -1645,7 +1645,7 @@ static int ipx_rcv(struct sk_buff *skb, 
 	if (!pskb_may_pull(skb, sizeof(struct ipxhdr)))
 		goto drop;
 
-	ipx_pktsize = ntohs(ipxhdr(skb)->ipx_pktsize);
+	ipx_pktsize = ntohs(ipx_hdr(skb)->ipx_pktsize);
 	
 	/* Too small or invalid header? */
 	if (ipx_pktsize < sizeof(struct ipxhdr) ||