Skip to contentSkip to conversation

aic23: Kconfig fixes for alsa and oss drivers.

PATCH In review lamikr 2 participants 4 messages May 25, 2006 – Aug 10, 2006 Sound

lore
Share & tools
lore

lamikr

author
#0 lore raw

PATCH 1/3 aic23: Kconfig fixes for alsa and oss drivers.

Kconfig fixes to prevent unselecting I2C and I2C-omap drivers is aic23 sound driver is selected.

Quoted 1 line

From nobody Mon Sep 17 00:00:00 2001

From: Mika Laitio <[email protected]>
Date: Thu May 25 22:46:18 2006 +0300
Subject: [PATCH 1/3] aic23: Kconfig fixes for alsa and oss drivers. I2C and I2C-OMAP must be build if aic23 driver is build.

---

 sound/arm/Kconfig |    2 ++
 sound/oss/Kconfig |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)

fafc1b62f86a4e85df544d38427a057e5304b6ea

sound/arm/Kconfig +2 -0
index cccdf23..fdf75e1 100644
@@ -37,6 +37,8 @@ config SND_OMAP_AIC23
 	tristate "OMAP AIC23 alsa driver (osk5912)"
 	depends on ARCH_OMAP && SND
 	select SND_PCM
+	select I2C
+	select I2C_OMAP if ARCH_OMAP
 	select SENSORS_TLV320AIC23
 	help
 	  Say Y here if you have a OSK platform board
sound/oss/Kconfig +2 -0
index 146cebf..3c2c587 100644
@@ -29,6 +29,8 @@ config SOUND_OMAP_TSC2101
 config SOUND_OMAP_AIC23
 	tristate "AIC23 Stereo Codec"
 	depends on SOUND_OMAP && ( MACH_OMAP_INNOVATOR || MACH_OMAP_OSK )
+	select I2C
+	select I2C_OMAP if ARCH_OMAP
 	select SENSORS_TLV320AIC23 if ARCH_OMAP
 	---help---
 	  AIC23 Audio Codec Driver for OMAP will be enabled.
Signature · 1 line
1.2.2
#1 lore raw
Quoted 2 lines · lamikr

Kconfig fixes to prevent unselecting I2C and I2C-omap drivers is aic23 sound driver is selected.

Pushing all 3 patches today.

Tony

author
#2 lore raw
Quoted 11 lines · Tony Lindgren
Quoted 3 lines · lamikr

Kconfig fixes to prevent unselecting I2C and I2C-omap drivers is aic23 sound driver is selected.

Pushing all 3 patches today.

Tony

Tony

I noticed that patches 2 and 3 are not applied. James Selvam tested that they were needed in order to get sounds working with innovator. Can you you still apply the old patches or should I resend them? (Send originally in 25.5.2006)

In addition to these, audio_process_dma from omap-alsa.c will also need one more fix that I can send separately.
(2 #ifdef CONFIG_MACH_OMAP_H6300 definitions must be changed to #ifdef CONFIG_ARCH_OMAP15XX)

Mika

#3 lore raw
Quoted 12 lines · lamikr
Quoted 11 lines · Tony Lindgren
Quoted 3 lines · lamikr

Kconfig fixes to prevent unselecting I2C and I2C-omap drivers is aic23 sound driver is selected.

Pushing all 3 patches today.

Tony

Quoted 6 lines

Tony

I noticed that patches 2 and 3 are not applied. James Selvam tested that they were needed in order to get sounds working with innovator. Can you you still apply the old patches or should I resend them? (Send originally in 25.5.2006)

Hmm, I wonder if these too got accidentally reverted a while back? Occasionally I miss new files with git-add too :)

Since you know exactly what's missing, can you please resend the missing patches?

Quoted 4 lines

In addition to these, audio_process_dma from omap-alsa.c will also need one more fix that I can send separately.
(2 #ifdef CONFIG_MACH_OMAP_H6300 definitions must be changed to #ifdef CONFIG_ARCH_OMAP15XX)

OK

Tony