OMAP: I2C driver for TI OMAP boards #4
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi Komal,
This one ended up in my spam box once again, although with a lower score (using the proper type for the attachement seems to have helped.) Maybe try with a shorter list of recipients next time, and add the name of people before their address.
Quoted 3 lines
Attached the updated patch as per the review comments on #3 patch.
Please consider it for the inclusion.
Looks good, I'll take it. One remaining objection:
Quoted 6 lines
(quoted diff) +6
-0+static int omap_i2c_get_clocks(struct omap_i2c_dev *dev) +{ + if (cpu_is_omap16xx() || cpu_is_omap24xx()) { + dev->iclk = clk_get(dev->dev, "i2c_ick"); + if (IS_ERR(dev->iclk)) { + dev->iclk = NULL;
Review
Quoted 10 lines
(quoted diff) +10
-0+ return -ENODEV; + } + } + + dev->fclk = clk_get(dev->dev, "i2c_fck"); + if (IS_ERR(dev->fclk)) { + if (dev->iclk != NULL) { + clk_put(dev->iclk); + dev->iclk = NULL; + return -ENODEV;
I think this return shouldn't be there.
Review
Quoted 7 lines
(quoted diff) +7
-0+ } + dev->fclk = NULL; + return -ENODEV; + } + + return 0; +}
I'll fix it myself if you agree, so that you don't have to resend a patch. Thanks for the good work! I'll send the patch upstream at the end of the week, so it should show in -mm soon.
Signature · 1 line
Jean Delvare
Quoted 8 lines · --- Jean Delvare
Hi Komal,
This one ended up in my spam box once again, although with a lower score (using the proper type for the attachement seems to have helped.)
Maybe try with a shorter list of recipients next time, and add the name
of people before their address.
I hope this doesn't end up in spam box ;).
Quoted 26 lines
Quoted 4 lines
Attached the updated patch as per the review comments on #3 patch.
Please consider it for the inclusion.
Looks good, I'll take it. One remaining objection:
Quoted 6 lines
(quoted diff) +6
-0+static int omap_i2c_get_clocks(struct omap_i2c_dev *dev) +{ + if (cpu_is_omap16xx() || cpu_is_omap24xx()) { + dev->iclk = clk_get(dev->dev, "i2c_ick"); + if (IS_ERR(dev->iclk)) { + dev->iclk = NULL;Review
Quoted 10 lines
(quoted diff) +10
-0+ return -ENODEV; + } + } + + dev->fclk = clk_get(dev->dev, "i2c_fck"); + if (IS_ERR(dev->fclk)) { + if (dev->iclk != NULL) { + clk_put(dev->iclk); + dev->iclk = NULL; + return -ENODEV;I think this return shouldn't be there.
Quoted 11 lines
Review
Quoted 7 lines
(quoted diff) +7
-0+ } + dev->fclk = NULL; + return -ENODEV; + } + + return 0; +}I'll fix it myself if you agree, so that you don't have to resend a patch. Thanks for the good work! I'll send the patch upstream at the end of the week, so it should show in -mm soon.
I am fine with that change. Thanx for the review.
---Komal Shah
http://komalshah.blogspot.com/
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com