Skip to contentSkip to conversation

spin lock imbalance in ibm emac

PATCH Superseded [email protected] 1 participant 1 message Aug 16, 2006 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spin lock imbalance in ibm emac

I'm not really sure where this code came from. There was a spin_unlock imbalance inside emac_start_xmit_sg().. It only effects the driver when CONFIG_IBM_EMAC_TAH is enabled.

This might need a little more review ..

drivers/net/ibm_emac/ibm_emac_core.c +3 -0
Index: linux-2.6.17/drivers/net/ibm_emac/ibm_emac_core.c
===================================================================
@@ -1140,6 +1140,8 @@ static int emac_start_xmit_sg(struct sk_
 	if (likely(!nr_frags && len <= MAL_MAX_TX_SIZE))
 		return emac_start_xmit(skb, ndev);
 
+	spin_lock(&dev->tx_lock);
+
 	len -= skb->data_len;
 
 	/* Note, this is only an *estimation*, we can still run out of empty
@@ -1208,6 +1210,7 @@ static int emac_start_xmit_sg(struct sk_
       stop_queue:
 	netif_stop_queue(ndev);
 	DBG2("%d: stopped TX queue" NL, dev->def->index);
+	spin_unlock(&dev->tx_lock);
 	return 1;
 }
 #else

--