powerpc: Make RTAS console init generic

PATCH New Michael Neuling 1 participant 1 message Aug 17, 2006

Subsystems (2)

PowerPC Cell broadband engine architecture

lore

Share & tools

lore

Michael Neuling

author

2006-08-17 04:12 UTC #0 lore raw

PATCH 1/1 powerpc: Make RTAS console init generic

The rtas console doesn't have to be Cell specific. If we get both RTAS tokens, we should just enabled the console then and there.

Signed-off-by Michael Neuling <[email protected]>

---
Fixed RTAS dependency bug.

 arch/powerpc/Kconfig                |    3 ++-
 arch/powerpc/kernel/rtas.c          |    5 +++++
 arch/powerpc/platforms/cell/setup.c |    4 ----
 3 files changed, 7 insertions(+), 5 deletions(-)

arch/powerpc/Kconfig +2 -1

Index: linux-2.6-ozlabs/arch/powerpc/Kconfig
===================================================================
@@ -426,7 +426,8 @@ config PPC_IBM_CELL_BLADE
 	select UDBG_RTAS_CONSOLE
 
 config UDBG_RTAS_CONSOLE
-	bool
+	bool "RTAS based debug console"
+	depends on PPC_RTAS
 	default n
 
 config XICS

arch/powerpc/kernel/rtas.c +5 -0

Index: linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
===================================================================
@@ -910,6 +910,11 @@ int __init early_init_dt_scan_rtas(unsig
 	basep = of_get_flat_dt_prop(node, "get-term-char", NULL);
 	if (basep)
 		rtas_getchar_token = *basep;
+
+	if (rtas_putchar_token != RTAS_UNKNOWN_SERVICE &&
+	    rtas_getchar_token != RTAS_UNKNOWN_SERVICE)
+		udbg_init_rtas_console();
+
 #endif
 
 	/* break now */

arch/powerpc/platforms/cell/setup.c +0 -4

Index: linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
===================================================================
@@ -150,10 +150,6 @@ static int __init cell_probe(void)
 	    !of_flat_dt_is_compatible(root, "IBM,CPBW-1.0"))
 		return 0;
 
-#ifdef CONFIG_UDBG_RTAS_CONSOLE
-	udbg_init_rtas_console();
-#endif
-
 	hpte_init_native();
 
 	return 1;