Alpha: replacing "extern inline"
I want to get rid of all "extern inline" in the kernel.
Why?
"extern inline" generates a warning with -Wmissing-prototypes and I'm currently working on getting the kernel cleaned up for adding this to the CFLAGS since it will help us to avoid a nasty class of runtime errors.
"extern inline" was required at the times when
__attribute__((always_inline)) wasn't avalable.
Nowadays, we use "static inline", and if there are places that really need a forced inline, we use "static __always_inline".
Can someone tell me which of the Alpha "static inline"'s need for some reason an __always_inline?
And a related question:
Does the never defined __IO_EXTERN_INLINE still have any purpose?
cu
Adrian
Signature · 6 lines
Gentoo kernels are 42 times more popular than SUSE kernels among
KLive users (a service by SUSE contractor Andrea Arcangeli that
gathers data about kernels from many users worldwide).
There are three kinds of lies: Lies, Damn Lies, and Statistics.
Benjamin DisraeliQuoted 1 line · Adrian Bunk
Why?
Because it inlines when it needs to, and does not generate out of line code when its address is taken.
Quoted 2 lines
Can someone tell me which of the Alpha "static inline"'s need for some reason an
__always_inline?
There shouldn't be any.
Quoted 1 line
Does the never defined
__IO_EXTERN_INLINEstill have any purpose?
It is defined.
$ grep 'define __IO_EXTERN_INLINE' * | wc -l 12
r~
Quoted 5 lines · Richard Henderson
Quoted 1 line · Adrian Bunk
Why?
Because it inlines when it needs to, and does not generate out of line code when its address is taken.
Ah, I start to remember.
Is this actually used anywhere in the kernel?
Quoted 11 lines
Quoted 2 lines
Can someone tell me which of the Alpha "static inline"'s need for some reason an
__always_inline?There shouldn't be any.
Quoted 1 line
Does the never defined
__IO_EXTERN_INLINEstill have any purpose?It is defined.
$ grep 'define __IO_EXTERN_INLINE' * | wc -l 12
Ups, I was blind...
Quoted 1 line
r~
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed