Skip to contentSkip to conversation

x86-64 add missing PMU MSR definitions

PATCH In review Stephane Eranian 2 participants 3 messages Aug 20, 2006 – Aug 22, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86-64 add missing PMU MSR definitions

Hello,

Here is a patch to add a couple of missing MSR definitions related to Performance monitoring for EM64T. A separate patch contains the i386 equivalent.

Changelog:
- add MSR definitions for IA32_PEBS_ENABLE and PEBS_MATRIX_VERT

Signature · 1 line
-Stephane
include/asm-x86_64/msr.h +3 -0
@@ -396,4 +396,7 @@ static inline unsigned int cpuid_edx(uns
 #define MSR_P4_U2L_ESCR0 		0x3b0
 #define MSR_P4_U2L_ESCR1 		0x3b1
 
+#define MSR_IA32_PEBS_ENABLE		0x3f1
+#define MSR_PEBS_MATRIX_VERT		0x3f2
+
 #endif
#1 lore raw
Quoted 8 lines · Stephane Eranian

Hello,

Here is a patch to add a couple of missing MSR definitions related to Performance monitoring for EM64T. A separate patch contains the i386 equivalent.

Changelog:
- add MSR definitions for IA32_PEBS_ENABLE and PEBS_MATRIX_VERT

The names seem somewhat mixed up.

I think I would prefer P4 and no IA32 prefixes for all of them. (or does Core2 still have PEBS?)

-Andi

#2 lore raw

Andi,

Quoted 7 lines · Andi Kleen
Quoted 6 lines · Stephane Eranian

Hello,

Here is a patch to add a couple of missing MSR definitions related to Performance monitoring for EM64T. A separate patch contains the i386 equivalent.

Quoted 8 lines
Quoted 2 lines

Changelog:
- add MSR definitions for IA32_PEBS_ENABLE and PEBS_MATRIX_VERT

The names seem somewhat mixed up.

I think I would prefer P4 and no IA32 prefixes for all of them. (or does Core2 still have PEBS?)

OK, let's wait until Intel *finally* releases the Core 2 PMU specification publicly and then I'll push a patch. Those MSRs are not that critical anyway. Perfmon2 is probably the only consumer.

Signature · 1 line
-Stephane