Skip to contentSkip to conversation

ipw2200: Reassociate even if set the same essid.

PATCH In review Zhu Yi 1 participant 1 message Aug 21, 2006

Subsystems (3)
Networking Network drivers Networking drivers (wireless)
lore
Share & tools
lore

Zhu Yi

author
#0 lore raw

PATCH 4/14 ipw2200: Reassociate even if set the same essid.

This patch traps the case when the essid is being set to its current value. If the essid is being set again and we are already associated, chances are some other parameters have also been altered. I think it is safer to do the re-association for this case.

Signed-off-by Bill Moss <[email protected]>
Signed-off-by Zhu Yi <[email protected]>

---

 drivers/net/wireless/ipw2200.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

17e85d1ad3dd9c8dc48d63dcc6cd531b3b8fb685

drivers/net/wireless/ipw2200.c +6 -5
index 27e87d1..e929f88 100644
@@ -8837,7 +8837,6 @@ static int ipw_wx_set_essid(struct net_d
 			    union iwreq_data *wrqu, char *extra)
 {
 	struct ipw_priv *priv = ieee80211_priv(dev);
-        char *essid;
         int length;
 
         mutex_lock(&priv->mutex);

@@ -8852,12 +8851,14 @@ static int ipw_wx_set_essid(struct net_d
                 return 0;
         }
 
-	length = min(wrqu->essid.length, IW_ESSID_MAX_SIZE);
-	essid = extra;
+	length = min((int)wrqu->essid.length, IW_ESSID_MAX_SIZE);
+	if (!extra[length - 1])
+		length--;
 
 	priv->config |= CFG_STATIC_ESSID;
 
-	if (priv->essid_len == length && !memcmp(priv->essid, extra, length)) {
+	if (priv->essid_len == length && !memcmp(priv->essid, extra, length)
+	    && (priv->status & (STATUS_ASSOCIATED | STATUS_ASSOCIATING))) {
 		IPW_DEBUG_WX("ESSID set to current ESSID.\n");
 		mutex_unlock(&priv->mutex);
 		return 0;

@@ -8867,7 +8868,7 @@ static int ipw_wx_set_essid(struct net_d
 		     length);
 
 	priv->essid_len = length;
-	memcpy(priv->essid, essid, priv->essid_len);
+	memcpy(priv->essid, extra, priv->essid_len);
 
 	/* Network configuration changed -- force [re]association */
 	IPW_DEBUG_ASSOC("[re]association triggered due to ESSID change.\n");
Signature · 1 line
1.2.6