ipw2200: Fix kernel Oops if cmdlog debug is enabled

PATCH In review Zhu Yi 1 participant 1 message Aug 21, 2006

Subsystems (3)

Networking Network drivers Networking drivers (wireless)

lore

Share & tools

lore

Zhu Yi

author

2006-08-21 03:40 UTC #0 lore raw

PATCH 10/14 ipw2200: Fix kernel Oops if cmdlog debug is enabled

When command error log debug is enabled, we write every host command and parameters into a buffer. But we didn't alloc the parameter buffer for this case. The patch adds struct cmdlog_host_cmd so that the buffer is allocated from the stack.

Signed-off-by Zhu Yi <[email protected]>

---

 drivers/net/wireless/ipw2200.h |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

b1822c22dbc0bd552b41f714ce38324325ecd8a5

drivers/net/wireless/ipw2200.h +8 -1

index 32b4ef8..a1df67f 100644
@@ -1950,10 +1950,17 @@ struct host_cmd {
 	u32 *param;
 } __attribute__ ((packed));
 
+struct cmdlog_host_cmd {
+	u8 cmd;
+	u8 len;
+	u16 reserved;
+	char param[124];
+} __attribute__ ((packed));
+
 struct ipw_cmd_log {
 	unsigned long jiffies;
 	int retcode;
-	struct host_cmd cmd;
+	struct cmdlog_host_cmd cmd;
 };
 
 /* SysConfig command parameters ... */

Signature · 1 line

1.2.6