Skip to contentSkip to conversation

sparc32: enabling of the 2nd CPU in 2.6.18-rc4

PATCH In review Krzysztof Helt 2 participants 2 messages Aug 24, 2006 – Aug 25, 2006 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc32: enabling of the 2nd CPU in 2.6.18-rc4

From: Krzysztof Helt ([email protected])

This is smp_setup_cpu_possible_map() move after the patch did by davem to sparc64.

---
This boots up the second CPU on my SS20. It is diff-ed agains 2.6.18-rc4 kernel, so maybe it was already posted by someone.

Regards,
Krzysztof

----------------------------------------------------
Games Convention Lipsk 23-27.08.2006 - Nie możesz tam być? Zobacz relacje na żywo:
http://klik.wp.pl/?adr=www.gc2006.gry.wp.pl&sid=852

arch/sparc/kernel/setup.c +2 -2
@@ -348,9 +348,9 @@ void __init setup_arch(char **cmdline_p)
 	init_mm.context = (unsigned long) NO_CONTEXT;
 	init_task.thread.kregs = &fake_swapper_regs;
 
-	smp_setup_cpu_possible_map();
-
 	paging_init();
+
+	smp_setup_cpu_possible_map();
 }
 
 static int __init set_preferred_console(void)
maintainer
#1 lore raw

From: "Krzysztof Helt" <[email protected]>
Date: Thu, 24 Aug 2006 22:44:51 +0200

Quoted 6 lines

From: Krzysztof Helt ([email protected])

This is smp_setup_cpu_possible_map() move after the patch did by davem to sparc64.

It took me a while to figure out what this patch was all about, please provide context and reasons why the change needs to be made.

I changed the changelog to what you should have said, to give you an idea:

--------------------
[SPARC]: enabling of the 2nd CPU in 2.6.18-rc4

smp_setup_cpu_possible_map() needs to run after paging_init() so that the in-kernel device tree is setup.

--------------------

See? If you had simply mentioned "paging_init() needs to run first so that the device tree is built and ready" I wouldn't have even needed to look at your patch :-)