Skip to contentSkip to conversation

collapse sv_init, init_sv on linux

PATCH In review [email protected] 2 participants 2 messages Aug 25, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 collapse sv_init, init_sv on linux

Change the one caller of init_sv on linux2.4 to sv_init, since there is no difference between sv_init & init_sv on linux anyway.

Then get rid of now unused init_sv.

 linux-2.4/sv.h        |    2 --
 linux-2.4/xfs_vnode.c |    2 +-
 linux-2.6/sv.h        |    2 --
 3 files changed, 1 insertion(+), 5 deletions(-)
linux-2.4/sv.h +0 -2
Index: xfs-linux/linux-2.4/sv.h
===================================================================
@@ -53,8 +53,6 @@ static inline void _sv_wait(sv_t *sv, sp
 	remove_wait_queue(&sv->waiters, &wait);
 }
 
-#define init_sv(sv,type,name,flag) \
-	init_waitqueue_head(&(sv)->waiters)
 #define sv_init(sv,flag,name) \
 	init_waitqueue_head(&(sv)->waiters)
 #define sv_destroy(sv) \
linux-2.4/xfs_vnode.c +1 -1
Index: xfs-linux/linux-2.4/xfs_vnode.c
===================================================================
@@ -35,7 +35,7 @@ vn_init(void)
 	register int i;
 
 	for (svp = vsync, i = 0; i < NVSYNC; i++, svp++)
-		init_sv(svp, SV_DEFAULT, "vsy", i);
+		sv_init(svp, SV_DEFAULT, "vsy");
 }
 
 struct bhv_vnode *
linux-2.6/sv.h +0 -2
Index: xfs-linux/linux-2.6/sv.h
===================================================================
@@ -53,8 +53,6 @@ static inline void _sv_wait(sv_t *sv, sp
 	remove_wait_queue(&sv->waiters, &wait);
 }
 
-#define init_sv(sv,type,name,flag) \
-	init_waitqueue_head(&(sv)->waiters)
 #define sv_init(sv,flag,name) \
 	init_waitqueue_head(&(sv)->waiters)
 #define sv_destroy(sv) \
#1 lore raw
Quoted 4 lines · On Thu, Aug 24, 2006 at 09:23:52PM -0500, [email protected] wrote:

Change the one caller of init_sv on linux2.4 to sv_init, since there is no difference between sv_init & init_sv on linux anyway.

Then get rid of now unused init_sv.

Taa, queued up (along with one or two earlier ones I didn't reply to yet).

thanks.

Signature · 1 line
Nathan