it87: Prevent overflow on fan clock

PATCH New Jean Delvare 1 participant 1 message Aug 28, 2006

Subsystems (2)

Hardware monitoring IT87 hardware monitoring driver

lore

Share & tools

lore

Jean Delvare

author

2006-08-28 12:26 UTC #0 lore raw

PATCH 6/14 it87: Prevent overflow on fan clock

Content-Disposition: inline; filename=hwmon-it87-div-to-reg-overflow.patch

it87: Prevent overflow on fan clock divider write

The highest possible clock divider for fan1 and fan2 is 128.

Signed-off-by Jean Delvare <khali at linux-fr.org>

---
 drivers/hwmon/it87.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/hwmon/it87.c +2 -2

@@ -198,7 +198,7 @@
 static int DIV_TO_REG(int val)
 {
 	int answer = 0;
-	while ((val >>= 1) != 0)
+	while (answer < 7 && (val >>= 1))
 		answer++;
 	return answer;
 }

@@ -562,7 +562,7 @@
 
 	struct i2c_client *client = to_i2c_client(dev);
 	struct it87_data *data = i2c_get_clientdata(client);
-	int val = simple_strtol(buf, NULL, 10);
+	unsigned long val = simple_strtoul(buf, NULL, 10);
 	int i, min[3];
 	u8 old;

Signature · 1 line

Jean Delvare