Moschip 7840 USB-Serial Driver

Worked with the tech support folks at Moschip Semiconductor to get the driver working on the latest kernel. We've been using it for a bit now and it appears to be working well. They're okay with kernel inclusion of the driver. I've cleaned it up a bit and put this patch together.

The patch is against 2.6.18-rc5. Please apply, it can be found here:
http://paul.schroeder.name/DEV/kernel/mos7840.patch

Thanks...Paul...

---

Paul B Schroeder <pschroeder "at" uplogix "dot" com>
Senior Software Engineer
Uplogix, Inc. (http://www.uplogix.com/)

Great, but can you submit it as per the Documentation/SubmittingPatches file?

Also, I've included the following text at the top of the file in my port of the mos7720 driver from the same developers. It also applies to this driver and you should add it too:

* Originally based on drivers/usb/serial/io_edgeport.c which is:
* Copyright (C) 2000 Inside Out Networks, All rights reserved.
* Copyright (C) 2001-2002 Greg Kroah-Hartman <[email protected]>

You can see the same function names and comments, as well as variable usages where they don't really need to be used.

Can you also please clean up those functions to be more kernel-like, and fix the variable names to follow the coding style rules of the kernel?

The #defines at the start of the file also can be removed, as they are not needed (TRUE and FALSE don't belong in a driver, use 0 and -ERR instead).

Also, look at the variables in struct moschip_port. A lot of them can be simply removed as they are never used. The wait queues are one example of these. And the use of the "__" type of variables should be examined, as I don't think it's necessary as these variables never cross the kernel/user boundry.

There are also a lot of global variables that should be static.

I'll go over the rest when you submit it in an email message so it can be quoted.

It's a great start though, I remember what the original version looked like :)

thanks,

greg k-h

On a slightly related topic, I've recently submitted a cleaned up version of the driver for the moschip 7830 USB-ethernet chip. I included the only address from Moschip that was known to me in all correspondence, but never got any comment from them.

Is there anyone from moschip that is qualified to comment on my code, or maybe even take over maintenance?

	Arnd <><