hwmon updates for 2.6.19

Hi Greg,

Here comes a 14-piece hwmon update patchset. There is a new driver for the thermal sensors embedded in AMD K8 CPUs, many fixes and improvements to the it87 driver, including support for the IT8716F and IT8718F, and a few other things. All these patches should go to -mm for now, and to 2.6.19 later.

Here's the summary:

Alexey Dobriyan:
o atxp1: Signed/unsigned char bug fix

Dmitry Torokhov:
o hdaps: Handle errors from input_register_device

Jean Delvare:
o smsc47m1: dev_warn fix
o it87: Add support for the IT8716F
o it87: No sysfs files for disabled fans
o it87: Prevent overflow on fan clock divider write
o it87: in8 has no limit registers
o it87: Cleanup set_fan_div
o it87: Add support for the IT8718F
o it87: Overwrite broken default limits
o it87: Copyright update
o k8temp: Enable automatic loading

Hans de Goede:
o abituguru: Add suspend/resume support

Rudolf Marek:
o hwmon: New driver k8temp

Statistics:

 Documentation/hwmon/it87  |   61 +++++++--
 drivers/hwmon/Kconfig     |   14 ++
 drivers/hwmon/Makefile    |    1 +
 drivers/hwmon/abituguru.c |   30 ++++-
 drivers/hwmon/atxp1.c     |    3 -
 drivers/hwmon/hdaps.c     |    6 +
 drivers/hwmon/it87.c      |  299 +++++++++++++++++++++++++++++++++++++--------
 drivers/hwmon/k8temp.c    |  294 ++++++++++++++++++++++++++++++++++++++++++++
 drivers/hwmon/smsc47m1.c  |    3 +
 include/linux/pci_ids.h   |    1 +
 10 files changed, 637 insertions(+), 75 deletions(-)

Jean Delvare

I've applied them all.

Care to work on all of the __must_check warnings that the hwmon code now spits out in the -mm and my trees? It's quite ugly :(

thanks,

greg k-h

Hi Greg,

Great, thanks :)

Mark M. Hoffman and others are already working on that:
http://lists.lm-sensors.org/pipermail/lm-sensors/2006-August/017463.html
http://lists.lm-sensors.org/pipermail/lm-sensors/2006-August/017204.html
http://lists.lm-sensors.org/pipermail/lm-sensors/2006-August/017462.html

I think we should have about half the drivers fixed for 2.6.19 at this rate. My own drivers are a bit delayed because I have some conflicting patches which I need to push to you first.

Note that we decided to abuse the fact that removing a sysfs file which doesn't exist is not considered an error. It makes our code much more simple. I hope there is no plan to change this behavior.

I still wonder how the sysfs file creation functions did qualify for __must_check while nothing bad actually happens if the files are not created. OK, the files are missing, but kernel-wise this doesn't cause any broken state as far as I can see.

I've already taken care of drivers/i2c, BTW. You picked the two core patches some times ago, and I have a third patch for the chip drivers which I will send to you soon (or you can pick it from the i2c list if you want it now.)

Jean Delvare

Great.

Hm, that works? Ah, nice, I need to remember it, as it would make my other cleanups easier too.

Why would you not check the return value of a function that provides you that information? :)

All of the driver core functions that return errors were marked in this manner due to a wide range of problems that we have been having for a while with drivers ignoring problems that the driver core has been reporting. We need to handle error conditions better, and this is finally forcing it to happen.

thanks,

greg k-h