Skip to contentSkip to conversation

NOMMU: Use find_vma() rather than reimplementing a VMA search

PATCH New David Howells 1 participant 1 message Aug 31, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NOMMU: Use find_vma() rather than reimplementing a VMA search

From: David Howells <[email protected]>

Use find_vma() in the NOMMU version of access_process_vm() rather than reimplementing it.

---

 mm/nommu.c |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)
mm/nommu.c +3 -8
index 663ec1c..51e17b9 100644
@@ -1039,6 +1039,7 @@ unsigned long do_mremap(unsigned long ad
 
 /*
  * Look up the first VMA which satisfies  addr < vm_end,  NULL if none
+ * - should be called with mm->mmap_sem at least readlocked
  */
 struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
 {
@@ -1213,7 +1214,6 @@ struct page *filemap_nopage(struct vm_ar
  */
 int access_process_vm(struct task_struct *tsk, unsigned long addr, void *buf, int len, int write)
 {
-	struct vm_list_struct *vml;
 	struct vm_area_struct *vma;
 	struct mm_struct *mm;
 
@@ -1227,13 +1227,8 @@ int access_process_vm(struct task_struct
 	down_read(&mm->mmap_sem);
 
 	/* the access must start within one of the target process's mappings */
-	for (vml = mm->context.vmlist; vml; vml = vml->next)
-		if (addr >= vml->vma->vm_start && addr < vml->vma->vm_end)
-			break;
-
-	if (vml) {
-		vma = vml->vma;
-
+	vma = find_vma(mm, addr);
+	if (vma) {
 		/* don't overrun this mapping */
 		if (addr + len >= vma->vm_end)
 			len = vma->vm_end - addr;