Skip to contentSkip to conversation

in 2.6.18-rc5

PATCH In review Jarek Poplawski 2 participants 3 messages Sep 1, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 in 2.6.18-rc5

Hi,

Some time ago I wrote about this bug in rc3.
I see it's still in 2.6.18-rc5 so here is what
I've found: with config like this:

CONFIG_SMP=y
CONFIG_PREEMPT=y
CONFIG_LOCKDEP=y
CONFIG_DEBUG_LOCK_ALLOC=y
# CONFIG_PROVE_LOCKING is not set

spin_unlock_irqrestore() goes through lockdep
but spin_lock_irqrestore() doesn't.

I attach my proposal how to fix this.

Jarek P.

kernel/spinlock.c +1 -1
diff -Nru linux-2.6.18-rc5-/kernel/spinlock.c linux-2.6.18-rc5/kernel/spinlock.c
@@ -72,7 +72,7 @@
  * not re-enabled during lock-acquire (which the preempt-spin-ops do):
  */
 #if !defined(CONFIG_PREEMPT) || !defined(CONFIG_SMP) || \
-	defined(CONFIG_PROVE_LOCKING)
+	defined(CONFIG_DEBUG_LOCK_ALLOC)
 
 void __lockfunc _read_lock(rwlock_t *lock)
 {
#1 lore raw

On Fri, Sep 01, 2006 at 08:43:19AM +0200, Jarek Poplawski wrote:
...

Quoted 2 lines

spin_unlock_irqrestore() goes through lockdep
but spin_lock_irqrestore() doesn't.

but spin_lock_irqsave() doesn't!

Jarek P.