Patch to add board revision to the WLAN chip_id printout
Subsystems (3)
RFC 1/1 Patch to add board revision to the WLAN chip_id printout
Michael,
This patch includes the board revision in the chip_id printk for the ssb version of bcm43xx-d80211 and is meant to be applied to wireless-dev. As we have seen, behavior of the chips can be dependent on the rev level, thus a need to have it in the log.
drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c +2 -1
@@ -3346,7 +3346,8 @@ static int bcm43xx_attach_board(struct bif (err) goto err_chipset_detach; - printk(KERN_INFO PFX "Broadcom %04X WLAN found\n", bcm->ssb.chip_id); + printk(KERN_INFO PFX "Broadcom %04X WLAN, Revision %d found\n", + bcm->ssb.chip_id, bcm->board_revision);/* Attach all IO cores to the backplane. */ coremask =0 ;
Quoted 5 lines · Larry Finger
Michael,
This patch includes the board revision in the
chip_idprintk for the ssb version of bcm43xx-d80211 and is meant to be applied to wireless-dev. As we have seen, behavior of the chips can be dependent on the rev level, thus a need to have it in the log.
Any specific example on this?
I mean, every revision in the chip (and bcm43xx has a _lot_) can (and does) change behaviour. But I still think we shouldn't print them all on initialization. ;)
Quoted 17 lines
Signed-off-by Larry Finger <[email protected]>Index:
wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
===================================================================drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c +2
-1@@ -3346,7 +3346,8 @@ static int bcm43xx_attach_board(struct bif (err) goto err_chipset_detach; - printk(KERN_INFO PFX "Broadcom %04X WLAN found\n", bcm->ssb.chip_id); + printk(KERN_INFO PFX "Broadcom %04X WLAN, Revision %d found\n", + bcm->ssb.chip_id, bcm->board_revision);/* Attach all IO cores to the backplane. */ coremask =0 ;
Signature · 1 line
Greetings Michael.