PM: Remove sleeping from suspend_console
PATCH 1/1 PM: Remove sleeping from suspend_console
Remove ssleep() from suspend_console().
Stefan thinks it is unnecessary and will slow down the suspend too much.
---
--- kernel/printk.c | 5 ----- 1 file changed, 5 deletions(-)
kernel/printk.c +0 -5
@@ -713,11 +713,6 @@ void suspend_console(void)printk ("Suspending console(s)\n" );acquire_console_sem (); console_suspended =1 ; -/* This is needed so that all of the messages that have already been -* written to all consoles can be actually transmitted (eg. over a -* network) before we try to suspend the consoles' devices. -*/ -ssleep (2 ); }void resume_console (void )
Quoted 3 lines · Rafael J. Wysocki
Remove
ssleep()fromsuspend_console().Stefan thinks it is unnecessary and will slow down the suspend too much.
"unnecessary" is not exactly what i think, rather "unacceptable" :-) We probably need to do something for some kinds of consoles to make sure all characters are sent, but sleeping unconditionally is not the right thing IMO.
Quoted 14 lines
kernel/printk.c +0
-5@@ -713,11 +713,6 @@ void suspend_console(void)printk ("Suspending console(s)\n" );acquire_console_sem (); console_suspended =1 ; -/* This is needed so that all of the messages that have already been -* written to all consoles can be actually transmitted (eg. over a -* network) before we try to suspend the consoles' devices. -*/ -ssleep (2 ); }void resume_console (void )
Signature · 3 lines
Stefan Seyfried QA / R&D Team Mobile Devices | "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."
Quoted 6 lines · Stefan Seyfried
Quoted 3 lines · Rafael J. Wysocki
Remove
ssleep()fromsuspend_console().Stefan thinks it is unnecessary and will slow down the suspend too much.
"unnecessary" is not exactly what i think, rather "unacceptable" :-)
Still that implies it's not necessary. ;-)
Quoted 2 lines
We probably need to do something for some kinds of consoles to make sure all characters are sent, but sleeping unconditionally is not the right thing IMO.
Yup. This was added as a result of the Laurent Riffard's report that the sleep was necessary, but it turned out to be due to the network card problem, so we should get rid of the ssleep().
Greetings,
Rafael
Signature · 2 lines
You never change things by fighting the existing reality. R. Buckminster Fuller