Skip to contentSkip to conversation

RFE: add io= option to 8250 serial console

PATCH In review Josef Whiter 2 participants 2 messages Sep 6, 2006 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RFE: add io= option to 8250 serial console

Hello,

This patch is against a recent git clone of Linus's tree. This patch adds the ability to set the iobase for the serial port being used when you specify a serial device for the console on bootup, ie

console=ttyS0,io=0x3f8

this is requested because boxes that use HP's iLo interface will usually redirect any output to ttyS0 to the iLo interface, which has a certain amount of latency associated with it. This option allows users to set the iobase for the port to the iLo's iobase which removes the need for the bios to do it's indirection. This has been tested by myself and HP and it works. Thank you,

Josef

drivers/serial/8250.c renamed from drivers/serial/8250.c.josef +25 -0
@@ -2304,6 +2304,31 @@ static int serial8250_console_setup(stru
 	if (!port->iobase && !port->membase)
 		return -ENODEV;
 
+	/*
+	 * if an io address is specified set the port's iobase to the 
+	 * specified port.  Parses the following option setups
+	 *	console=ttyS0,io=0x3f8
+	 *	console=ttyS0,115200n8,io=0x3f8
+	 *	console=ttyS0,io=0x3f8,115200n8
+	 */
+	if (options) {
+		char *ioptr;
+		unsigned long iobase = 0;
+		if ((ioptr = strstr(options, "io=")) != NULL) {
+			iobase = simple_strtoul(ioptr+3, NULL, 16);
+			if (ioptr == options) {
+				if((ioptr = strstr(options, ",")) != NULL)
+					options = ioptr+1;
+				else
+					options = (char *)0;
+			} else
+				*(ioptr-1) = '\0';
+		}
+
+		if (iobase)
+			port->iobase = iobase;
+	}
+
 	if (options)
 		uart_parse_options(options, &baud, &parity, &bits, &flow);
 
#1 lore raw
Quoted 5 lines · Josef Whiter

This patch is against a recent git clone of Linus's tree. This patch adds the ability to set the iobase for the serial port being used when you specify a serial device for the console on bootup, ie

console=ttyS0,io=0x3f8

Have you looked at 8250_early.c already in the kernel?

console= [KNL] Output console device and options.

uart,io,<addr>[,options] uart,mmio,<addr>[,options]
Start an early, polled-mode console on the 8250/16550 UART at the specified I/O port or MMIO address, switching to the matching ttyS device later. The options are the same as for ttyS, above.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core