Skip to contentSkip to conversation

bootwrapper: add flat device tree support code

PATCH In review Mark A. Greer 3 participants 7 messages Sep 8, 2006 – Sep 11, 2006 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bootwrapper: add flat device tree support code

This patch adds a copy of the flat device tree code to the bootwrapper. This code is only a copy of what exists in a mercurial repository that can be cloned:
"hg clone http://unsanctioned.org/flatdevtree/hgweb.py flatdevtree"

Do not edit this file in the bootwrapper, send patches to Hollis Blanchard <[email protected]> and CC: [email protected].

--

 Makefile      |    2 
 flatdevtree.c |  628 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 flatdevtree.h |  106 +++++++++
 3 files changed, 735 insertions(+), 1 deletion(-)

--

arch/powerpc/boot/Makefile +1 -1
index 44a3055..1c4f11b 100644
@@ -40,7 +40,7 @@ src-boot := crt0.S string.S stdio.c main
 ifeq ($(CONFIG_PPC_MULTIPLATFORM),y)
 src-boot += of.c
 else
-src-boot += flatdevtree_misc.c
+src-boot += flatdevtree.c flatdevtree_misc.c
 endif
 ifeq ($(CONFIG_SANDPOINT),y)
 src-boot += sandpoint.c mpc10x.c simple_alloc.c serial.c ns16550.c util.S
arch/powerpc/boot/flatdevtree.c new file +628 -0

628 lines not on this page · raw message

arch/powerpc/boot/flatdevtree.h new file +106 -0

106 lines not on this page · raw message

#1 lore raw

arch/powerpc/boot/flatdevtree.c line 8

Quoted 11 lines · Mark A. Greer
arch/powerpc/boot/flatdevtree.c new file +8 -0
@@ -0,0 +1,628 @@
+/*
+ * DO NOT EDIT THIS FILE!!
+ *
+ * The master copy is kept in a mercurial repository that you can clone:
+ *	"hg clone http://unsanctioned.org/flatdevtree/hgweb.py flatdevtree"
+ * Please send patches to Hollis Blanchard <[email protected]> and
+ * CC: <[email protected]>
+ *

Actually I'm not intending for that to be a long-term URL. If we need something permanent for this file, I can set something up on penguinppc.org...

(NAK)

-Hollis

#2 lore raw
Quoted 17 lines · Hollis Blanchard

arch/powerpc/boot/flatdevtree.c line 8

Quoted 11 lines · Mark A. Greer
arch/powerpc/boot/flatdevtree.c new file +8 -0
@@ -0,0 +1,628 @@
+/*
+ * DO NOT EDIT THIS FILE!!
+ *
+ * The master copy is kept in a mercurial repository that you can clone:
+ *	"hg clone http://unsanctioned.org/flatdevtree/hgweb.py flatdevtree"
+ * Please send patches to Hollis Blanchard <[email protected]> and
+ * CC: <[email protected]>
+ *

Actually I'm not intending for that to be a long-term URL. If we need something permanent for this file, I can set something up on penguinppc.org...

Quoted 1 line

(NAK)

Okay. May as well wait for Paul's changes for doing much more anyway.

Mark

#3 lore raw
In reply to Hollis Blanchard
Quoted 17 lines · Hollis Blanchard

arch/powerpc/boot/flatdevtree.c line 8

Quoted 11 lines · Mark A. Greer
arch/powerpc/boot/flatdevtree.c new file +8 -0
@@ -0,0 +1,628 @@
+/*
+ * DO NOT EDIT THIS FILE!!
+ *
+ * The master copy is kept in a mercurial repository that you can clone:
+ *	"hg clone http://unsanctioned.org/flatdevtree/hgweb.py flatdevtree"
+ * Please send patches to Hollis Blanchard <[email protected]> and
+ * CC: <[email protected]>
+ *

Actually I'm not intending for that to be a long-term URL. If we need something permanent for this file, I can set something up on penguinppc.org...

Quoted 3 lines

(NAK)

-Hollis

Wasn't there a notion of even combining this with
the DTC code base directly? I haven't seen any
patches or motion down this line, though...?

Thanks,
jdl

#4 lore raw
Quoted 4 lines · Jon Loeliger

Wasn't there a notion of even combining this with
the DTC code base directly? I haven't seen any
patches or motion down this line, though...?

That's certainly a good place the new code could be applied. Of course, I haven't sent patches to uboot, iseries boot code, kexec, or any other number of places either, and don't really plan to. If those areas have problems, they can switch to the consolidated codebase then (rather than bugfixing the non-consolidated code).

Why, are you going to convert DTC?

-Hollis

#5 lore raw
Quoted 5 lines · Hollis Blanchard

That's certainly a good place the new code could be applied. Of course, I haven't sent patches to uboot, iseries boot code, kexec, or any other number of places either, and don't really plan to. If those areas have problems, they can switch to the consolidated codebase then (rather than bugfixing the non-consolidated code).

I'm worried about the code-duplication factor here...

Quoted 1 line

Why, are you going to convert DTC?

I'm not opposed to accepting patches. :-)

jdl

#6 lore raw
Quoted 9 lines · Jon Loeliger
Quoted 5 lines · Hollis Blanchard

That's certainly a good place the new code could be applied. Of course, I haven't sent patches to uboot, iseries boot code, kexec, or any other number of places either, and don't really plan to. If those areas have problems, they can switch to the consolidated codebase then (rather than bugfixing the non-consolidated code).

I'm worried about the code-duplication factor here...

The functionality has already been duplicated, and more was on the way. The consolidated code prevents that from spreading, but by itself doesn't replace any of the existing duplication.

Quoted 3 lines
Quoted 1 line

Why, are you going to convert DTC?

I'm not opposed to accepting patches. :-)

Have fun.

-Hollis