boot failes when strange value is specified for dom0_max_vcpus

PATCH In review MINAI Katsuhito 1 participant 3 messages Aug 31, 2006 – Oct 18, 2006

lore

Share & tools

lore

MINAI Katsuhito

author

2006-08-31 05:05 UTC #0 lore raw

PATCH 1/1 boot failes when strange value is specified for dom0_max_vcpus

Hi,

This patch corrects the following bug.

The startup of Xen fails when the following values are specified for boot option dom0_max_vcpus.

- Value more than number of physical CPU
- Negative value

Signed-off-by Katsuhito Minai <[email protected]>

xen/arch/x86/domain_build.c +2 -0

diff -r f790546ecfda xen/arch/x86/domain_build.c
@@ -671,6 +671,8 @@ int construct_dom0(struct domain *d,
 
     if ( opt_dom0_max_vcpus == 0 )
         opt_dom0_max_vcpus = num_online_cpus();
+    if ( opt_dom0_max_vcpus > num_online_cpus() )
+        opt_dom0_max_vcpus = num_online_cpus();
     if ( opt_dom0_max_vcpus > MAX_VIRT_CPUS )
         opt_dom0_max_vcpus = MAX_VIRT_CPUS;
     printk("Dom0 has maximum %u VCPUs\n", opt_dom0_max_vcpus);

Best regards,
Minai

MINAI Katsuhito

author

2006-09-11 07:10 UTC #1 lore raw

Hi,

I think this behavior is a bug.
Could you apply this patch ?
Or please give me comments.

thanks,
Katsuhito Minai

Quoted 33 lines · On Thu, 31 Aug 2006 14:05:09 +0900 MINAI Katsuhito <[email protected]> wrote:

Hi,
This patch corrects the following bug.
The startup of Xen fails when the following values are specified for boot option dom0_max_vcpus.
- Value more than number of physical CPU
- Negative value
Signed-off-by Katsuhito Minai <[email protected]>
diff -r f790546ecfda xen/arch/x86/domain_build.c
xen/arch/x86/domain_build.c +2 -0
@@ -671,6 +671,8 @@ int construct_dom0(struct domain *d,
 
     if ( opt_dom0_max_vcpus == 0 )
         opt_dom0_max_vcpus = num_online_cpus();
+    if ( opt_dom0_max_vcpus > num_online_cpus() )
+        opt_dom0_max_vcpus = num_online_cpus();
     if ( opt_dom0_max_vcpus > MAX_VIRT_CPUS )
         opt_dom0_max_vcpus = MAX_VIRT_CPUS;
     printk("Dom0 has maximum %u VCPUs\n", opt_dom0_max_vcpus);
Best regards,
Minai

Quoted 4 lines

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

   /  | /  | 富士通(株)プラットフォーム技開本 仮想システム開発統括部
  /   |/   |_*_ __ __  ___ _*_ 藥 袋 克 仁 email:[email protected]
 / /|   /| || |/ |/ |_/  |_| | Phone:055-924-6194 Ex:7551-5366
/_/ |__/ |_||_|-|_/|_//_|_/|_| FAX:  055-924-6148 FAX-ex.7551-6571

MINAI Katsuhito

author

2006-10-18 06:15 UTC #2 lore raw

In reply to MINAI Katsuhito

Hi,

I think this behavior is a bug.
Could you apply this patch ?
Or please give me comments.

thanks,
Katsuhito Minai

Quoted 33 lines · On Thu, 31 Aug 2006 14:05:09 +0900 MINAI Katsuhito <[email protected]> wrote:

Hi,
This patch corrects the following bug.
The startup of Xen fails when the following values are specified for boot option dom0_max_vcpus.
- Value more than number of physical CPU
- Negative value
Signed-off-by Katsuhito Minai <[email protected]>
diff -r f790546ecfda xen/arch/x86/domain_build.c
xen/arch/x86/domain_build.c +2 -0
@@ -671,6 +671,8 @@ int construct_dom0(struct domain *d,
 
     if ( opt_dom0_max_vcpus == 0 )
         opt_dom0_max_vcpus = num_online_cpus();
+    if ( opt_dom0_max_vcpus > num_online_cpus() )
+        opt_dom0_max_vcpus = num_online_cpus();
     if ( opt_dom0_max_vcpus > MAX_VIRT_CPUS )
         opt_dom0_max_vcpus = MAX_VIRT_CPUS;
     printk("Dom0 has maximum %u VCPUs\n", opt_dom0_max_vcpus);
Best regards,
Minai

Quoted 4 lines

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

   /  | /  | 富士通(株)プラットフォーム技開本 仮想システム開発統括部
  /   |/   |_*_ __ __  ___ _*_ 藥 袋 克 仁 email:[email protected]
 / /|   /| || |/ |/ |_/  |_| | Phone:055-924-6194 Ex:7551-5366
/_/ |__/ |_||_|-|_/|_//_|_/|_| FAX:  055-924-6148 FAX-ex.7551-6571