Skip to contentSkip to conversation

smc911x: Undocumented interrupt now reserved

PATCH In review [email protected] 2 participants 2 messages Sep 13, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 11/12 smc911x: Undocumented interrupt now reserved

In Rev B silicon

	#define    INT_STS_RXDF_INT_               (0x00400000)  /* R/WC */

seems reserved.

drivers/net/smc911x.c +1 -1
Index: linux-2.6.18-rc4/drivers/net/smc911x.c
===================================================================
@@ -1127,7 +1125,7 @@
 			lp->stats.rx_dropped+=SMC_GET_RX_DROP();
 		 }
 		/* Undocumented interrupt-what is the right thing to do here? */
-		if (status & INT_STS_RXDF_INT_) {
+		if (IS_REV_A(lp->revision) && status & INT_STS_RXDF_INT_) {
 			SMC_ACK_INT(INT_STS_RXDF_INT_);
 		}
 
#1 lore raw

[email protected] <[email protected]> :
[...]

drivers/net/smc911x.c line 1128

Quoted 6 lines
drivers/net/smc911x.c +1 -1
@@ -1127,7 +1125,7 @@
 			lp->stats.rx_dropped+=SMC_GET_RX_DROP();
 		 }
 		/* Undocumented interrupt-what is the right thing to do here? */
-		if (status & INT_STS_RXDF_INT_) {
+		if (IS_REV_A(lp->revision) && status & INT_STS_RXDF_INT_) {

Extra parenthesis please.

Signature · 1 line
Ueimor