Skip to contentSkip to conversation

smc911x: phy_check_media reverses MAC duplex settings

PATCH In review [email protected] 1 participant 1 message Sep 13, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 9/12 smc911x: phy_check_media reverses MAC duplex settings

Datasheet says, page: 98 -> http://www.smsc.com/main/datasheets/9115.pdf

"MAC_CR_RCVOWN_ should be reset when the Full
Duplex Mode bit is set" and "When MAC_CR_FDPX_ set, the MAC operates in Full-Duplex mode, in which it can transmit and receive simultaneously."

drivers/net/smc911x.c +3 -2
Index: linux-2.6.18-rc4/drivers/net/smc911x.c
===================================================================
@@ -927,14 +923,15 @@
 		/* duplex state has changed */
 		SMC_GET_PHY_BMCR(phyaddr, bmcr);
 		SMC_GET_MAC_CR(cr);
+		cr &= ~(MAC_CR_RCVOWN_ | MAC_CR_FDPX_);
 		if (lp->mii.full_duplex) {
 			DBG(SMC_DEBUG_MISC, "%s: Configuring for full-duplex mode\n", dev->name);
 			bmcr |= BMCR_FULLDPLX;
-			cr |= MAC_CR_RCVOWN_;
+			cr |= MAC_CR_FDPX_;
 		} else {
 			DBG(SMC_DEBUG_MISC, "%s: Configuring for half-duplex mode\n", dev->name);
 			bmcr &= ~BMCR_FULLDPLX;
-			cr &= ~MAC_CR_RCVOWN_;
+			cr |= MAC_CR_RCVOWN_;
 		}
 		SMC_SET_PHY_BMCR(phyaddr, bmcr);
 		SMC_SET_MAC_CR(cr);