Skip to contentSkip to conversation

smc911x: phy_configure releases spinlocks before grabing

PATCH In review [email protected] 2 participants 2 messages Sep 13, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 10/12 smc911x: phy_configure releases spinlocks before grabing

phy_configure releases spinlocks before grabing...

drivers/net/smc911x.c +4 -3
Index: linux-2.6.18-rc4/drivers/net/smc911x.c
===================================================================
@@ -961,17 +958,17 @@
 	int status;
 	unsigned long flags;
 
-	DBG(SMC_DEBUG_FUNC, "%s: --> %s()\n", dev->name, __FUNCTION__);
+	DBG(SMC_DEBUG_FUNC, "%s: --> %s\n", dev->name, __FUNCTION__);
 
 	/*
 	 * We should not be called if phy_type is zero.
 	 */
 	if (lp->phy_type == 0)
-		 goto smc911x_phy_configure_exit;
+		 goto smc911x_phy_configure_early_exit;
 
 	if (smc911x_phy_reset(dev, phyaddr)) {
 		printk("%s: PHY reset timed out\n", dev->name);
-		goto smc911x_phy_configure_exit;
+		goto smc911x_phy_configure_early_exit;
 	}
 	spin_lock_irqsave(&lp->lock, flags);
 
@@ -1040,6 +1037,7 @@
 
 smc911x_phy_configure_exit:
 	spin_unlock_irqrestore(&lp->lock, flags);
+smc911x_phy_configure_early_exit:	
 	lp->work_pending = 0;
 }
 
#1 lore raw

[email protected] <[email protected]> :
[...]

drivers/net/smc911x.c line 1039

Quoted 4 lines
drivers/net/smc911x.c +0 -0
@@ -1040,6 +1037,7 @@
 
 smc911x_phy_configure_exit:
 	spin_unlock_irqrestore(&lp->lock, flags);

The change is fine but I'd rename this one as
${some_random_string_}out_unlock as well.

Signature · 1 line
Ueimor